← Back to issue list

style: remove pylint comments

View original Github issue

Metadata

Project
snapcraft
Number
#4848
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged cleanup removing remaining pylint comments. Approved by two reviewers, passed CI checks, and updated two files with minimal changes.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Remove the last few pylint references that were probably added in between #4817 and the ROS2 Jazzy PRs

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged cleanup removing remaining pylint comments. Approved by two reviewers, passed CI checks, and updated two files with minimal changes.
qwen3.6-35b-a3b-mtp-q6 Merged style cleanup removing remaining pylint comments and references from the codebase. Lint and test checks passed prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged cleanup changes that removed remaining pylint comments from the codebase. All lint and test checks passed, finalizing the removal of legacy pylint references.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#118 style: remove pylint craft-store merged Merged to remove pylint from the project. Approved by one reviewer, passed CI checks, and modified two files with a net reduction of three lines.
88%
#4817 style: remove pylint snapcraft merged Merged removal of pylint configuration, fully replaced by ruff. Approved by three reviewers, passed CI checks, and modified 46 files across the codebase.
81%
#2222 style: fix linting issues charmcraft merged Merged following approval by two reviewers. Resolved linting issues across three files with minor style adjustments (+8/-9 lines). No review comments or CI checks were required.
80%
#291 lint: remove leftover pylint directive craft-parts merged Merged a change removing a leftover pylint directive. The single-line deletion across one file received reviewer approval and was integrated after passing checks.
79%
#2229 style: fix linting errors charmcraft merged Merged changes resolving linting errors from the latest ruff and pyright. Approved by two reviewers with zero unresolved comments. Updated 8 files, removing 22 lines overall.
78%
#29 tests: address pylint issues craft-parts merged Merged to address pylint warnings in test files. Approved by three reviewers and passed CI. The update modified three files, adding seven and removing four lines.
76%
#1039 docs: update changelog craft-parts merged Merged changelog update. Approved by two reviewers with minimal changes across two files. No CI checks or comments were required.
75%
#66 lint: update pylint configuration craft-store merged Merged an update to the pylint configuration, removing 627 lines of outdated settings and adding 16 lines with no functional changes. Approved by a reviewer and passed all CI checks.
75%
#1757 Minor cleanup charmcraft merged Merged a minor cleanup pull request approved by two reviewers. The update removed 122 lines and added 70 across 23 files, refactoring code without introducing functional changes.
75%
#57 tests: update pylint and address new warnings craft-parts merged Merged after two approvals and passing CI. Updated pylint to 2.8.2 and resolved newly introduced linting warnings in the test suite with minor code adjustments across a single file.
75%