← Back to issue list

style: remove pylint comments

View original Github issue

Metadata

Project
snapcraft
Number
#4848
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged as snapcraft#4848 (commit f5e002565): a small two-file style cleanup deleting the last remaining pylint comments left over after #4817, approved by two reviewers.

Resolution: closed resolved

Reason: The PR was merged into main as commit f5e002565 ("style: remove pylint comments (#4848)"), removing the residual pylint disable comments across 2 files (+2/-4 lines) with 2 approving reviewers and no unresolved comments.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Remove the last few pylint references that were probably added in between #4817 and the ROS2 Jazzy PRs

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as snapcraft#4848 (commit f5e002565): a small two-file style cleanup deleting the last remaining pylint comments left over after #4817, approved by two reviewers.
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#4848 (commit f5e002565), removing the last pylint references left after #4817. The two-file cleanup was approved by two reviewers.
qwen/qwen3.6-35b-a3b — — Merged cleanup removing remaining pylint comments. Approved by two reviewers, passed CI checks, and updated two files with minimal changes.
qwen3.6-35b-a3b-mtp-q6 — — Merged style cleanup removing remaining pylint comments and references from the codebase. Lint and test checks passed prior to merge.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4817 (confidence 95%)

    Earlier merged PR that removed the pylint configuration; #4848 cleaned up the few pylint comments reintroduced after it by the ROS 2 Jazzy PRs.

  • Related To: snapcraft#4712 (confidence 80%)

    Tracking issue for moving linting to ruff, which made the pylint configuration and comments redundant.

Related issues

Issue Project State Summary Similarity
#291 lint: remove leftover pylint directive craft-parts merged Merged PR #291 in commit fb583a60, removing one leftover pylint directive from a single file.
70%