← Back to issue list

docs: exclude overlay step, bump craft-parts to 1.34.0

View original Github issue

Metadata

Project
snapcraft
Number
#4948
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/snapcraft#4948, fixing the docs build by excluding overlay-step docs and bumping craft-parts to 1.34.0 (f57f7e0c0, de13316cb).

Resolution: closed resolved

Reason: PR #4948 was merged after review, resolving the failing documentation build. Its commits exclude the problematic overlay-step material and update craft-parts to 1.34.0.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Fix failing snapcraft doc build due to https://github.com/canonical/craft-parts/pull/765, which added a reference to an excluded overlays explanation. Depends on https://github.com/canonical/craft-parts/pull/795 ### Changelog #### 1.34.0 (2024-08-01) - Allow numbers in partitions, partition namespaces, and namespaced partitions. - Add documentation for chisel and the overlay step - Improve README onboarding Unblocks CRAFT-3043

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#4948, fixing the docs build by excluding overlay-step docs and bumping craft-parts to 1.34.0 (f57f7e0c0, de13316cb).
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#4948: fixed the failing docs build, excluded overlay-step docs, and bumped craft-parts to 1.34.0.
qwen/qwen3.6-35b-a3b — — Merged to fix a failing snapcraft doc build triggered by craft-parts 1.34.0. Updates exclude overlay step references and bump the dependency to 1.34.0, resolving the failure and unblocking CRAFT-3043.
qwen3.6-35b-a3b-mtp-q6 — — Merged after updating craft-parts to 1.34.0 and excluding the overlay step from documentation. This resolves a failing doc build triggered by an upstream reference and unblocks CRAFT-3043.

Update history

No update history recorded yet.

Related work

  • Caused By: canonical/craft-parts#765 (confidence 98%)

    It added the overlay explanation reference that caused the Snapcraft documentation build failure.

  • Related To: canonical/craft-parts#795 (confidence 98%)

    It was identified as the craft-parts prerequisite for the 1.34.0 update.

Related issues

Issue Project State Summary Similarity
#4183 requirements: update craft-parts to 1.21.0 snapcraft merged Merged PR #4183 updated Snapcraft's craft-parts requirement to 1.21.0 in commit 8f6a8b353, aligning it with new base and overlay package callbacks.
76%
#5036 build(deps): bump craft-parts to 1.33.1 snapcraft closed Closed unmerged in favor of canonical/snapcraft#5031, which merged as a24dc3e49 and bumped craft-parts to 1.33.1, making the npm plugin stateless.
75%
#4645 build(deps): update craft-parts to 1.27 snapcraft closed Closed unmerged as redundant because merged PR canonical/snapcraft#4635 (055a93543) already included the craft-parts 1.27 update.
74%
#4679 refactor(docs): use more docs from craft-parts snapcraft merged Merged #4679 as b8c9a17dc, replacing duplicated Snapcraft docs with direct craft-parts TOC references or includes for shared content.
74%
#4083 requirements: update craft-parts to 1.19.0 snapcraft merged Merged PR #4083 (commit 0e2cf91be) bumped craft-parts to 1.19.0, adopting feature selection that makes the overlay step optional and improving dirty checks for plugin-specific property changes.
74%
#5603 build(deps): update craft-parts to 2.16.0 snapcraft merged Merged PR #5603 as commit 161cf6c40, updating craft-parts to 2.16.0 and restoring Snapcraft documentation intersphinx links after upstream target changes.
73%
#4811 build(deps): bump craft-parts to 1.31.0 snapcraft merged Merged PR #4811 bumped craft-parts to 1.31.0 to add a new set of plugin docs; resolving merge commit a32f01a21.
73%
#137 many: add overlay step (CRAFT-84) craft-parts merged Merged craft-parts#137 as commit 1a813210, adding the overlay lifecycle step and subsystem support for package installation and filesystem mutations.
72%
#218 requirements: update craft-parts to 1.19.0 rockcraft merged Merged as commit 3c9fc942: bumped craft-parts to 1.19.0, enabled overlays (now required by that release), and updated OS release verification in tests after Craft Parts dropped Ubuntu codenames.
72%
#6481 build(deps): bump craft-parts to 2.35.2 snapcraft merged Merged dependency bump to craft-parts 2.35.2 and added Snapcraft 9.1.4 release notes.
72%