← Back to issue list

fix: configure icon for snaps without apps

View original Github issue

Metadata

Project
snapcraft
Number
#4950
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Maintainer mr-cal's PR merged (commit c9d9cc227), fixing a core22 regression where Snapcraft 7 skipped icon configuration for snaps with no apps. Fixes #4936, landed via hotfix/7.5 and released in 7.5.6.

Resolution: closed resolved

Reason: PR #4950 was approved and merged as commit c9d9cc227, restoring asset/icon setup for apps-less snaps. The maintainer's follow-up comment redirected it to hotfix/7 via PR #4954, and the fix shipped in Snapcraft 7.5.6, closing issue #4936.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Always configure and install icons for snaps even if they do not have any `apps` defined in their `snapcraft.yaml` file. This looks like a regression introduced in core22 [here](https://github.com/canonical/snapcraft/pull/3702/files#diff-0eaeb159bf22a93ac8d7fe8db572236d6a88d712904c605f2d458495bfcc7dc1R52) based on [this legacy code](https://github.com/canonical/snapcraft/blob/780f2aadfb260048e58a1b2d6892bc0b3f5d9b0e/snapcraft_legacy/internal/meta/_snap_packaging.py#L515). Fixes https://github.com/canonical/snapcraft/issues/4936 (CRAFT-3189)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Maintainer mr-cal's PR merged (commit c9d9cc227), fixing a core22 regression where Snapcraft 7 skipped icon configuration for snaps with no apps. Fixes #4936, landed via hotfix/7.5 and released in 7.5.6.
stealth/space-bunny-alpha — closed resolved Merged in #4950 (commit c9d9cc227), fixing core22 regression where snapcraft 7 ignored configured icons for snaps without apps; released in 7.5.6.
qwen/qwen3.6-35b-a3b — — Merged fix addressing a regression that skipped icon configuration for snaps without apps. Approved by two reviewers, passed CI, and retargeted to the hotfix/7 branch for maintenance.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for a regression that skipped icon configuration for snaps without apps. Icons are now always installed. The change requires retargeting to the hotfix/7 branch via PR #4954.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#4936 (confidence 95%)

    The linked issue 'snapcraft 7 ignores icon path in snapcraft.yaml' that this PR explicitly fixes; closed by the merge.

  • Related To: canonical/snapcraft#4954 (confidence 85%)

    Maintainer requested retargeting #4950 onto hotfix/7 via PR #4954, which was merged to repair CI/spread tests on that branch.

  • Caused By: canonical/snapcraft#3702 (confidence 60%)

    The core22 change cited in the PR body as the source of the regression that skipped icon setup when no apps are defined.

Related issues

Issue Project State Summary Similarity
#4936 snapcraft 7 ignores icon path in snapcraft.yaml snapcraft closed Regression in core22 Snapcraft 7 (icon not copied when no apps section) was fixed by merged PR #4950 (commit c9d9cc227, 'fix: configure icon for snaps without apps'), backported and released in 7.5.6 to 7.x/stable.
79%