fix: configure icon for snaps without apps
Metadata
Current evaluation
Merged fix addressing a regression that skipped icon configuration for snaps without apps. Approved by two reviewers, passed CI, and retargeted to the hotfix/7 branch for maintenance.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Always configure and install icons for snaps even if they do not have any `apps` defined in their `snapcraft.yaml` file.
This looks like a regression introduced in core22 [here](https://github.com/canonical/snapcraft/pull/3702/files#diff-0eaeb159bf22a93ac8d7fe8db572236d6a88d712904c605f2d458495bfcc7dc1R52) based on [this legacy code](https://github.com/canonical/snapcraft/blob/780f2aadfb260048e58a1b2d6892bc0b3f5d9b0e/snapcraft_legacy/internal/meta/_snap_packaging.py#L515).
Fixes https://github.com/canonical/snapcraft/issues/4936
(CRAFT-3189)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix addressing a regression that skipped icon configuration for snaps without apps. Approved by two reviewers, passed CI, and retargeted to the hotfix/7 branch for maintenance. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for a regression that skipped icon configuration for snaps without apps. Icons are now always installed. The change requires retargeting to the hotfix/7 branch via PR #4954. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for a regression preventing icon configuration in snaps without apps. Retargeted to hotfix/7 via PR #4954 to resolve issue #4936. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #530 fix: add artifact type for snap store icon | fetch-service | merged | Merged a fix adding the artifact type for the snap store icon. Approved by two reviewers and passed all CI checks. The change updated three files with a net addition of three lines. | |
| #4936 snapcraft 7 ignores icon path in snapcraft.yaml | snapcraft | closed | Fixed a regression where snapcraft 7 ignored the icon path when the apps section was missing. Resolved via PR #4950 by correcting asset setup order. Released in snapcraft 7.5.6 and version 8. | |
| #5087 fix: allow parallel installations of signed snapcraft snaps (7.5) | snapcraft | merged | Merged into hotfix/7.5 to fix parallel installation failures for signed snapcraft snaps. Backports the solution from #5058, resolving issues #4683 and #4927. Approved by two reviewers with all CI checks passing. |