← Back to issue list

tests: update spread tests in hotfix/7.5

View original Github issue

Metadata

Project
snapcraft
Number
#4954
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4954 into hotfix/7.5 with six cherry-picks and six commits repairing CI and spread tests; it unblocked icon fixes for #4950 and #4936.

Resolution: closed resolved

Reason: PR #4954 was approved and merged into hotfix/7.5, repairing CI and spread tests. Its description explicitly states that it unblocked #4950 and #4936.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- 6 cherry-picks and 6 new commits to repair CI and spread tests in `hotfix/7.5`. The readthedocs CI failure is expected as Snapcraft 7 predates readthedocs integration. Unblocks #4950 and #4936 Unblocks CRAFT-3189

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4954 into hotfix/7.5 with six cherry-picks and six commits repairing CI and spread tests; it unblocked icon fixes for #4950 and #4936.
stealth/space-bunny-alpha — closed resolved PR #4954 merged into hotfix/7.5, adding six cherry-picks and six commits to repair CI and spread tests; it unblocked #4950 and #4936.
qwen/qwen3.6-35b-a3b — — Merged into hotfix/7.5 to update spread tests and repair CI. The branch includes six cherry-picks and six new commits, passed all CI and coverage checks, received reviewer approval, and unblocked issues #4950 and #4936.
qwen3.6-35b-a3b-mtp-q6 — — Merged into hotfix/7.5. Six cherry-picks and six new commits updated spread tests and repaired CI. All modified lines passed coverage checks, unblocking related issues and stabilizing the branch.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4950 (confidence 99%)

    PR #4954 explicitly identifies #4950 as unblocked; #4950 fixed the snap-without-apps icon regression released in 7.5.6.

  • Related To: canonical/snapcraft#4936 (confidence 99%)

    PR #4954 explicitly identifies #4936 as unblocked; the icon regression was resolved through #4950.

  • Related To: canonical/snapcraft#4979 (confidence 85%)

    The 7.5.6 hotfix line, which contained the #4954 test repairs, was subsequently merged into main through #4979.

Related issues

Issue Project State Summary Similarity
#3986 Hotfix/7.2 merge snapcraft merged PR #3986 was merged into main as the 7.2 hotfix after unit tests returned to green and the new spread test passed.
76%
#5736 test: fix hotfix/7.5 workflows snapcraft merged Merged PR #5736 repaired hotfix/7.5 CI and test workflows with cherry-picks from main across 39 files; all reported checks passed, resolving #5617.
75%
#863 ci: run spread tests on hotfix branches craft-application merged Merged PR #863 as commit 25dbf6d0, adding hotfix/* to spread-test push triggers so hotfix branches no longer require an admin branch-creation override.
75%
#5786 ci: run spread on push to main/hotfix snapcraft merged Merged PR #5786 as commit db2b03097, adding Spread test runs for pushes to main and hotfix/** branches.
75%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%.
74%
#127 Fix spread tests imagecraft merged Fixed and merged as commit cd43de1, updating 11 files (+49/-38); all listed CI checks, including spread, passed.
73%
#3662 tests: update spread url snapcraft merged Merged PR #3662 updated Spread tarball URLs in two test files via commit 507959d70.
73%
#4924 tests: add spread tests for validation-sets snapcraft merged Merged PR #4924 added spread coverage for edit-validation-sets and list-validation-sets, closing #4918; merge commit 157d0a182.
72%
#5075 tests: fix validation sets spread test snapcraft merged Merged PR #5075 (commit a22b218ab) fixed #5053 by making the validation-sets spread test use hello-world and check presence instead of a fixed revision.
72%
#5617 Fix hotfix/7.5 CI snapcraft closed Fixed in merged PR #5736, which brought test and workflow fixes from main into hotfix/7.5; all reported checks passed.
72%