← Back to issue list

remote build: Allow comma-separated values for `--build-for` and `--platform`

View original Github issue

Metadata

Project
snapcraft
Number
#4990
Type
issue
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Regression in remote-build parsing of comma-separated `--build-for`/`--platform` values was restored by merged PR #5028 (commit 189edf429). Maintainer mr-cal closed the issue on 2024-09-13 pointing to #5028.

Resolution: closed resolved

Reason: PR #5028 ('fix(remotebuild): parse comma-separated architectures', commit 189edf429) was merged and re-added the comma-splitting logic lost in the craft-application migration. Maintainer mr-cal commented 'Fixed via #5028' before closing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Allow comma-separated values for `--build-for` and `--platform` for new remote builder. [This logic](https://github.com/snapcore/snapcraft/blob/ffbdabf53de21606d9d12e15f16d4bca5e4423a5/snapcraft_legacy/cli/remote.py#L267) or [this logic](https://github.com/canonical/snapcraft/pull/4543/files#diff-f0ddf54498a8af347d3e38035ffe604b2febcbf2429f4cbe3df2e4db39a838c1R102) needs to be added to the remote-build command. ### Why it needs to get done To fix a regression. This was fixed once in the first migration of the remote builder via https://github.com/canonical/snapcraft/issues/4516 and regressed again when remote-builder was migrated to craft-application.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Regression in remote-build parsing of comma-separated `--build-for`/`--platform` values was restored by merged PR #5028 (commit 189edf429). Maintainer mr-cal closed the issue on 2024-09-13 pointing to #5028.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR #5028 (commit 189edf429, "fix(remotebuild): parse comma-separated architectures"), restoring comma-separated parsing for remote-build --build-for/--platform; maintainer closed the issue citing that PR.
stealth/space-bunny-alpha — closed resolved Comma-separated values for --build-for and --platform were restored in remote build by merged PR #5028, fixing regression #4990.
qwen/qwen3.6-35b-a3b — — Fixed via PR #5028. The remote build command now supports comma-separated values for --build-for and --platform, resolving a regression introduced during the migration to craft-application.
qwen/qwen3.6-35b-a3b — — Fixed via PR #5028 by enabling comma-separated values for the --build-for and --platform remote builder flags, resolving a regression from the craft-application migration.
qwen/qwen3.6-35b-a3b — — Comma-separated value support for the --build-for and --platform flags was added to the remote builder to fix a regression. The request was closed and fixed via pull request #5028.
qwen/qwen3.6-35b-a3b — — Fixed via PR #5028 by adding comma-separated value support for the --build-for and --platform arguments in the remote builder, resolving a regression introduced during the craft-application migration.
qwen3.6-35b-a3b-mtp-q6 — — Comma-separated value support for --build-for and --platform in the remote builder was added to resolve a regression from the craft-application migration. The fix was merged via pull request #5028.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#5028 (confidence 98%)

    Merged PR restoring comma-separated --build-for/--platform parsing, cited in the closing comment

  • Related To: canonical/snapcraft#4543 (confidence 70%)

    Earlier PR that first implemented the comma-separated parsing that regressed

  • Related To: canonical/snapcraft#4516 (confidence 60%)

    Original report of the same regression during the first remote-builder migration

Related issues

Issue Project State Summary Similarity
#5028 fix(remotebuild): parse comma-separated architectures snapcraft merged Merged PR #5028 (commit 189edf429) restored comma-separated parsing for remote-build --build-for and --platform, fixing #4990.
82%
#4994 fix(remotebuild): parse '--build-for' and '--platform' snapcraft merged Merged as 5cd480725: remote-build now parses and validates --build-for and --platform, enforces usage restrictions, and updates error and command documentation.
77%
#4516 regression: remote-build doesn't accept comma-seperated architectures snapcraft closed Comma-separated remote-build architectures were fixed by merged PR #4543 (b8eed87c0); a later regression was superseded by #4990 and fixed by merged PR #5028 (189edf429).
72%
#6453 fix(remote-build): error with a resolution when '--platform' is used snapcraft closed PR #6453 proposed clearer remote-build --platform guidance pointing to --build-for, but was closed unmerged after no review; issue #5387 remains open.
70%