← Back to issue list

chore: delete empty shellcheckrc file

View original Github issue

Metadata

Project
snapcraft
Number
#5287
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged PR removing an accidentally committed empty shellcheckrc file. Approved by two reviewers and passed CI, successfully cleaning the repository root.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `make test`? --- There was an empty shellcheckrc file mistakenly brought in by the Starbase merge, this just removes it to clean up the top-level of the repo a bit.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged PR removing an accidentally committed empty shellcheckrc file. Approved by two reviewers and passed CI, successfully cleaning the repository root.
qwen3.6-35b-a3b-mtp-q6 Merged a cleanup change removing an empty shellcheckrc file mistakenly added during a previous merge. The maintainer deleted the file to tidy the repository root.
qwen3.6-35b-a3b-mtp-q6 Merged a cleanup commit that removes an accidentally committed empty shellcheckrc file from the repository root.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#359 chore: delete empty shellcheckrc file starbase merged Merged deletion of an empty shellcheckrc file. The file provided no functionality and was already being removed by repository adopters. Approved by a reviewer and passed CI checks.
93%
#1291 chore(ci): enable shellcheck charmcraft merged Merged. The change adds a single line to enable shellcheck in the CI pipeline. Approved by two reviewers with no comments or CI failures.
80%
#6079 chore: delete unused file snapcraft merged Merged a pull request removing an unused file following a migration to a pyproject-based setup. The change was approved by two reviewers, passed all CI checks, and deleted three lines from a single file.
76%
#14 chore(ci): add shellcheck and yamllint snapcraft-rocks merged Merged. Resolves issue #9 by adding shellcheck and yamllint to the CI pipeline. Approved by one reviewer. Updates 5 files with 49 additions and 7 deletions.
76%
#422 chore: delete mistakenly committed project file imagecraft merged Merged after approval. Deletes a project file mistakenly committed in PR #287. Required CI checks passed, and the change was successfully integrated into the repository.
75%
#2682 chore: delete some dead code charmcraft open Removes 19 lines of dead code in one file, a follow-up to #2681 (remote-build project name fix). Approved by a maintainer, CI mostly green with a few failing/pending snap tests.
75%
#5821 chore(legacy): remove script entry point snapcraft merged Merged removal of a legacy script entry point causing user confusion. Approved by two reviewers, passed CI checks, and deleted a single line in one file to clean up the codebase.
75%
#373 chore: clean up an unused field from the completion script craft-cli merged Merged cleanup removing an unused field from the completion script, identified via lint workflow. Approved by two reviewers with all CI checks passing. Changes affect three files with minimal line adjustments.
74%
#2271 chore: release 3.4.5 charmcraft merged Merged as release 3.4.5. Approved by three reviewers. Two CI checks failed but did not block the merge.
74%
#392 chore: remove codeowners starbase merged Merged after approval from two reviewers and passing all CI checks. The change removes the CODEOWNERS file, deleting 9 lines from a single file as discussed in standup.
74%