← Back to issue list

chore(ci): add shellcheck and yamllint

View original Github issue

Metadata

Project
snapcraft-rocks
Number
#14
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged canonical/snapcraft-rocks#14, adding ShellCheck and yamllint to CI and resolving issue #9.

Resolution: closed resolved

Reason: PR canonical/snapcraft-rocks#14 was approved and merged, adding the requested lint checks. Its description explicitly states that it fixes #9, whose closure record confirms the resolution.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #9

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft-rocks#14, adding ShellCheck and yamllint to CI and resolving issue #9.
stealth/space-bunny-alpha — closed resolved Merged snapcraft-rocks#14, adding shellcheck and yamllint to CI and resolving #9.
qwen/qwen3.6-35b-a3b — — Merged. Resolves issue #9 by adding shellcheck and yamllint to the CI pipeline. Approved by one reviewer. Updates 5 files with 49 additions and 7 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged, integrating shellcheck and yamllint into the CI pipeline. Resolves issue #9. Changes were applied directly by the maintainer without additional comments.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft-rocks#9 (confidence 100%)

    Issue requesting ShellCheck linting for spread tests; resolved by merged PR #14.

Related issues

Issue Project State Summary Similarity
#1291 chore(ci): enable shellcheck charmcraft merged Merged #1291, enabling ShellCheck in CI through a one-line workflow configuration change; resolving commit 4ae36bb6.
79%
#9 lint spread tests with shellcheck snapcraft-rocks closed Added ShellCheck linting for spread tests via merged PR canonical/snapcraft-rocks#14 ("chore(ci): add shellcheck and yamllint"), which also enabled yamllint. Maintainer tigarmo closed the issue with "Fixed by #14".
75%
#291 lint: add shellcheck, yamllint craft-providers merged Merged PR #291 in commit 68ac1cc, adding shellcheck and yamllint from Starbase to address #287.
74%
#443 chore(linter): fix some annotation errors rockcraft merged Merged canonical/rockcraft#443 to fix linter annotation errors across 14 files (+97/-55); the maintainer-authored change was approved by two reviewers.
71%
#51 chore(deps): update dependency yamllint to v1.31.0 starbase merged Renovate dependency bump yamllint 1.29.0 -> 1.31.0 merged into main as commit 9de5c85; one-line .pre-commit-config.yaml change, approved and no failing CI. Later superseded by #178 (v1.33.0).
71%
#5287 chore: delete empty shellcheckrc file snapcraft merged Merged in canonical/snapcraft#5287 via commit 3ecf821dc, deleting the empty .shellcheckrc accidentally introduced during a Starbase merge.
71%
#19 chore(ci): have renovate update snapcraft snapcraft-rocks merged PR #19 merged, adding an 18-line renovate.json (regex customManager on rockcraft.yaml + baseBranchPatterns for coreNN branches) so Renovate bumps canonical/snapcraft versions on live branches; landed as commit e1a4987.
71%