chore: remove unused _read_config
Metadata
Current evaluation
Closed without merging; superseded by a reworked branch pushed directly to canonical/snapcraft under work/refactor/*.
Resolution: closed superseded
Reason: Author/maintainer lengau closed the PR with the comment 'Superseded: reworking the branch layout to work/refactor/* and pushing directly to canonical/snapcraft.' The same change was reopened as PR #6473.
Evaluated by: mr-cal-bot
No scores available.
Issue body
`_read_config` in `snapcraft/commands/account.py` has no callers anywhere in the repo. It reads a login file from disk for a command that no longer exists, so it is dead code left behind when the deprecated store commands were removed.
This also drops the `pathlib` import, which was only used by that function.
No behaviour change.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest | — | closed superseded | Closed without merging; superseded by a reworked branch pushed directly to canonical/snapcraft under work/refactor/*. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Superseded By:
canonical/snapcraft#6473
(confidence 90%)
Open PR #6473 carries the identical title and change (removing dead _read_config and the pathlib import), matching the superseding rework.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6472 chore: remove unused set_legacy_env | snapcraft | closed | Closed unmerged; author superseded it by reworking branch layout to work/refactor/* and pushing directly to canonical/snapcraft. | |
| #6473 chore: remove unused _read_config | snapcraft | merged | Merged PR removing dead _read_config helper and unused pathlib import from snapcraft/commands/account.py; no behaviour change. | |
| #6470 chore: remove unused errors | snapcraft | closed | PR removing unused SnapcraftError subclasses was closed unmerged; superseded by reworking the branch layout and pushing directly to canonical/snapcraft. | |
| #6241 chore: remove snapcraft_legacy | snapcraft | merged | Merged #6241 via commits ffb164b7a and 995f0a3bc, deleting snapcraft_legacy, obsolete specs, and legacy-only dependencies after its entry points were removed. | |
| #6035 chore!: remove deprecated commands | snapcraft | merged | Merged as 3623601d7, removing deprecated Snapcraft commands and options and resolving #5674 (SNAPCRAFT-1196). | |
| #6079 chore: delete unused file | snapcraft | merged | Merged PR #6079 as commit 75686f3da, deleting a three-line file unused since Snapcraft moved to a pyproject-based setup. | |
| #1078 chore!: remove deprecated APIs | craft-application | merged | Merged PR #1078 as 3334f13e, removing eight deprecated APIs and fixing #1063. All CI checks passed, with local Snapcraft verification. | |
| #5183 chore(merge): 8.5.1 into main | snapcraft | merged | Merged Snapcraft 8.5.1 into main via #5183 (merge commit bfb63fa79), after approval by two reviewers. | |
| #6474 chore: remove unused errors | snapcraft | merged | Merged PR removing three unused SnapcraftError subclasses (InvalidArchitecture, ArchAllInvalid, ProjectMissing) and a stale comment in services/init.py; no behavior change. | |
| #5994 chore!: remove legacy remote builder | snapcraft | merged | Merged PR #5994 as b08f1a66e, removing the legacy remote builder and closing #5676 for Snapcraft 9.0. |