test(spread): update store tests
Metadata
Current evaluation
Merged #5371 (commits 3067b4bac/6979dd634, CRAFT-4419): adjusted snapcraft store spread tests and CI secrets after re-provisioning, pointing metrics tests at the testing snap, base64-encoding credentials, and using new staging keys.
Resolution: closed resolved
Reason: PR #5371 was approved and merged into main as commit 3067b4bac ('test(spread): update store tests'), fixing five failing store spread tests (basic-workflow candid/legacy/ubuntu_one, confdbs, validation-sets) after store secrets were re-provisioned. It depended on the merged prerequisite #5356 (de5ab3e29).
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
Only the second commit needs to be reviewed (the tiny one).
All of snapcraft's secrets were re-provisioned from Sergio's credentials to mine and it broke some of the store tests.
This PR adjusts the tests and the secrets.
| failing test | fix |
| -------------------------------------------- | ---------------------------------------------------------------------------- |
| tests/spread/store/basic-workflow:candid | use the testing snap for `snapcraft metrics` |
| tests/spread/store/basic-workflow:legacy | use base64 encoding for the credentials |
| tests/spread/store/basic-workflow:ubuntu_one | use the testing snap for `snapcraft metrics` |
| tests/spread/store/confdbs | use a new key registered on the staging store |
| tests/spread/store/validation-sets | use a new key registered on the staging store |
Needs #5356
(CRAFT-4419)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #5371 (commits 3067b4bac/6979dd634, CRAFT-4419): adjusted snapcraft store spread tests and CI secrets after re-provisioning, pointing metrics tests at the testing snap, base64-encoding credentials, and using new staging keys. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #5371, updating store tests and credentials after secret re-provisioning; changed metrics snaps, base64 credential handling, and staging keys to restore store-test coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as #5371 (commit 6979dd634), updating store spread tests and staging credentials after secret re-provisioning broke metrics, base64 credential, confdbs, and validation-sets tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after updating store tests and credentials following a secret re-provisioning that broke existing tests. Adjusted configurations for metrics, base64 credential encoding, and staging store keys to restore test functionality. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updated store spread tests for re-provisioned credentials. Fixed failures by using testing snaps for metrics, base64 encoding credentials, and registering new staging store keys. Depends on PR #5356. |
Update history
No update history recorded yet.
Related work
-
Blocked By:
canonical/snapcraft#5356
(confidence 95%)
PR body states 'Needs #5356'; merged as de5ab3e29 (confdbs renamed to confdb-schema), which the confdbs test updates follow.
-
Related To:
canonical/snapcraft#5954
(confidence 70%)
Later merged PR 0be1e384d again fixed store spread tests, moving them to new staging credentials/key test-staging-key-2 — a follow-up to the same credential-rotation breakage.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #386 tests: update testing to use craft-test | fetch-service | merged | Merged #386 as commit 323b0e1, replacing direct Spread calls with snapcraft test and updating the test base to core24. | |
| #5954 tests: fix store tests | snapcraft | merged | PR #5954 merged as commit 0be1e384d: store spread tests switched to new staging credentials/key test-staging-key-2 and to wheel-based automated tests (as in #5885). | |
| #5370 test: fix store tests | snapcraft | closed | Store-test fixes were superseded by merged #5954, updating credentials and configuration after secret re-provisioning in commit 0be1e384d. | |
| #1272 tests: initial setup for the snapcraft snap tests with spread | snapcraft | merged | Merged PR #1272 as commit 545344442, adding initial Spread-based test infrastructure for the snapcraft snap. | |
| #86 tests: update store tests for new image | craft-store | merged | Merged in canonical/craft-store#86, updating store tests for the new image and adding reproduction instructions; the author confirmed all tests passed with none skipped. | |
| #5845 test(spread): test building base and snapd snaps | snapcraft | merged | Merged as fb8c81e8f, adding manual Spread coverage that builds current base snaps and the snapd snap against mainline Snapcraft. | |
| #1460 fix(tests): make store spread tests less flaky | charmcraft | merged | Merged PR #1460 as fd5bd6ba, making store spread tests less timing-sensitive and fixing flaky upload/release checks in #1429. | |
| #3090 ci: move staging store tests to spread | snapcraft | merged | Merged into master in commit 3a037fb11, moving staging store tests from the legacy suite to Spread and removing 1,434 lines across 27 files. | |
| #1797 tests: update the snap name already registered for store tests | snapcraft | merged | Updated store tests to use a currently registered, non-revoked snap after the previous test name was revoked; merged as commit 4cf4f33a. | |
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged in commit 34ab4bdd, cleaning up store spread tests by deleting 28 lines across four files; the remaining library-test failure was fixed separately in #1292. |