← Back to issue list

test(spread): clean up store tests

View original Github issue

Metadata

Project
charmcraft
Number
#1290
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers.

Suggested action:

No scores available.

Issue body

library test failure still occurs but is fixed in #1292

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers.
qwen3.6-35b-a3b-mtp-q6 Merged store test cleanup. A pre-existing library test failure was addressed and resolved in pull request #1292.
qwen3.6-35b-a3b-mtp-q6 Merged cleanup of store tests. A pre-existing library test failure was noted and resolved in PR #1292.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1460 fix(tests): make store spread tests less flaky charmcraft merged Merged following approval by two reviewers and successful CI checks. The change resolves issue #1429 by adjusting two files to reduce flakiness in store spread tests, with a net diff of +7/-4 lines.
85%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration.
82%
#1325 test(spread): consolidate basic init/build tests charmcraft merged Merged after approval by two reviewers. Consolidates basic init and build spread tests across four files, reducing 80 lines and adding 28. Resolves CRAFT-2127.
81%
#127 Fix spread tests imagecraft merged Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
80%
#3432 spread tests: remove legacy plugin tests snapcraft merged Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR.
80%
#1366 tests(spread): make release test less flaky charmcraft merged Merged changes that reduce flakiness in the spread release test, resolving issue #1362. Approved by two reviewers, the update modifies one file (+17/-7) after addressing feedback.
80%
#13 test(spread): add more spread tests snapcraft-rocks merged Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines).
79%
#6350 test: fix spread tests snapcraft merged Merged after fixing non-store spread tests and the OSV scanner. Pinned black to 26.3.1 to resolve patchelf segfaults and silent failures. Approved by two reviewers and passed CI checks.
79%
#1223 tests: fix resource spread test charmcraft merged Merged to fix the resource spread test, advancing progress toward issue #1193. The update modified two files (+44/-23 lines) and was approved by two reviewers. Related library and store test corrections are addressed in separate pull requests.
79%
#534 test(spread): workaround for flaky test fetch-service merged Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks.
79%