test(spread): clean up store tests
Metadata
Current evaluation
Merged in commit 34ab4bdd, cleaning up store spread tests by deleting 28 lines across four files; the remaining library-test failure was fixed separately in #1292.
Resolution: closed resolved
Reason: PR #1290 was merged as 34ab4bdd, completing the store-test cleanup. Follow-up PR #1292, merged as 99a5a505, fixed the remaining library-test failure.
Evaluated by: mr-cal-bot
No scores available.
Issue body
library test failure still occurs but is fixed in #1292
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit 34ab4bdd, cleaning up store spread tests by deleting 28 lines across four files; the remaining library-test failure was fixed separately in #1292. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1290 in commit 34ab4bdd, cleaning up store spread tests by removing 28 lines across four files. The remaining library-test failure was fixed separately in #1292. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged charmcraft#1290, removing 28 lines from four store-test files. The remaining library-test failure was fixed separately in charmcraft#1292. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5954 cleaned up spread store tests, removing 28 lines across four files. A remaining library test failure was addressed separately in #1292. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged store test cleanup. A pre-existing library test failure was addressed and resolved in pull request #1292. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1292
(confidence 100%)
Explicitly identified in PR #1290 as the fix for the remaining library-test failure.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%. | |
| #3090 ci: move staging store tests to spread | snapcraft | merged | Merged into master in commit 3a037fb11, moving staging store tests from the legacy suite to Spread and removing 1,434 lines across 27 files. | |
| #1460 fix(tests): make store spread tests less flaky | charmcraft | merged | Merged PR #1460 as fd5bd6ba, making store spread tests less timing-sensitive and fixing flaky upload/release checks in #1429. | |
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged PR #1325 as commit 90e25caf, consolidating basic Spread init/build tests for CRAFT-2127 and reducing duplicated setup across four files. | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged #1366 at commit 05b18a03, reducing flakiness in the Spread release test and resolving #1362. | |
| #1223 tests: fix resource spread test | charmcraft | merged | Merged #1223 (commit 35993996), fixing the flaky store-resources spread test and advancing #1193; related store fixes landed in #1226 and #1234. | |
| #5954 tests: fix store tests | snapcraft | merged | PR #5954 merged as commit 0be1e384d: store spread tests switched to new staging credentials/key test-staging-key-2 and to wheel-based automated tests (as in #5885). | |
| #3089 ci: move staging store tests to spread | snapcraft | closed | Superseded by merged PR #3090, which moved staging store tests to Spread in commit 3a037fb11. | |
| #6350 test: fix spread tests | snapcraft | merged | Merged PR #6350 as a18c7f485, fixing all non-store Spread tests and OSV scanning, including pinning Black 26.3.1 to avoid patchelf failures. | |
| #1292 test(spread): make library tests register/unregister charms | charmcraft | merged | Merged #1292 in commit 99a5a505, making library spread tests register and unregister charms and fixing store-timeout failures in #1279. |