← Back to issue list

test: update multi-key test for package repositories

View original Github issue

Metadata

Project
snapcraft
Number
#5412
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged test updates adding a new valid GPG key to replace an expired apt.puppet.com key, resolving failing multi-key repository tests. The change passed review and CI. Reviewers recommended migrating to a team-controlled PPA to prevent future expiration issues.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- One of the keys on https://apt.puppet.com expired on 2025-Apr-06, causing our multi-key tests to fail. This PR adds a new, apparently valid key to the keyring with: ```bash # create a new keyring with the bad, existing keys gpg --keyring ./new-key.gpg --no-default-keyring --import < ~/Projects/craft/snapcraft/tests/spread/core24/package-repositories/test-multi-keys/snap/keys/9E61EF26.asc # add the https://apt.puppet.com/DEB-GPG-KEY-future key which apparently is valid gpg --keyring ./new-key.gpg --no-default-keyring --import < ~/Downloads/DEB-GPG-KEY-future # export the key as ascii gpg --keyring ./new-key.gpg --no-default-keyring --export -a > new-9E61EF26.asc # inspect the keyring: gpg --with-colons --no-default-keyring --import-options show-only --import < new-9E61EF26.asc ```

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged test updates adding a new valid GPG key to replace an expired apt.puppet.com key, resolving failing multi-key repository tests. The change passed review and CI. Reviewers recommended migrating to a team-controlled PPA to prevent future expiration issues.
qwen3.6-35b-a3b-mtp-q6 Merged test updates adding a new valid GPG key to replace an expired apt.puppet.com key, resolving failing multi-key package repository tests. A maintainer suggested migrating to a team-controlled PPA to prevent future expiration issues if they recur.
qwen3.6-35b-a3b-mtp-q6 Merged test update adding a new valid GPG key to replace an expired apt.puppet.com key, fixing failing multi-key tests. Suggested migrating to a team-controlled PPA to prevent recurrence, agreed as a contingency.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#29 repo: replace "apt-key" with "gpg" to handle keys craft-archives merged Merged update replacing the deprecated apt-key command with gpg for repository key management. Adds integration tests, removes an obsolete mock, and resolves CRAFT-1626. Approved by reviewers, passed CI checks, and increased test coverage by 0.03%.
72%
#4253 package-repositories: update craft-archives to support multi-keys. snapcraft merged Merged after approval and passing CI. Updates craft-archives to support multi-keys for package-repositories. Codecov reported no coverage change, while an unrelated spread error was tracked in PR #4256.
71%