← Back to issue list

fix(tests): create a suitable build plan

View original Github issue

Metadata

Project
snapcraft
Number
#4643
Type
pull request
State
closed
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

PR #4643 (test fix creating a suitable build plan) was closed unmerged: maintainer mr-cal noted its commits landed via PR #4659 ("fix: update to craft-application latest"), squashed as commit aab0797cf.

Resolution: closed superseded

Reason: Closed by maintainer mr-cal on 2024-03-13 with the comment "Closing because the commits here were merged in via #4659." PR #4659 was merged and includes commit aab0797cf "fix(tests): create a suitable build plan" in mainline history.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #4643 (test fix creating a suitable build plan) was closed unmerged: maintainer mr-cal noted its commits landed via PR #4659 ("fix: update to craft-application latest"), squashed as commit aab0797cf.
stealth/space-bunny-alpha — closed superseded Test fix PR #4643 ('fix(tests): create a suitable build plan') was closed unmerged by maintainer mr-cal on 2024-03-13 because its commits were already merged via #4659 (craft-application update).
stealth/space-bunny-alpha — closed superseded Test changes from PR #4643 were consolidated and merged through #4659, which updated Snapcraft for craft-application’s latest breaking changes.
qwen/qwen3.6-35b-a3b — — Closed and superseded. The changes were merged into the main branch via pull request #4659.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #4659, which merged the commits. The changes fixed tests by creating a suitable build plan.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#4659 (confidence 95%)

    Merged PR that consolidated #4643's test changes while updating to craft-application's latest breaking changes (commit aab0797cf).

Related issues

Issue Project State Summary Similarity
#5375 test: fix command tests snapcraft merged Test-only PR by maintainer mr-cal merged as commit 28cb1b828 ("test: fix command tests (#5375)"), updating fixtures for failing command unit tests (CRAFT-4414); +17/-9 across 2 files, approved by 2 reviewers.
73%
#4609 [test] check proposed craft-application feature snapcraft closed Closed unmerged after the maintainer reported the proposed craft-application test succeeded; the temporary three-file test PR was abandoned.
71%
#5529 fix: remove test artifact workaround snapcraft merged Merged PR #5529 removed the test-artifact lookup workaround after craft-application 3.5, landing as commit 8fbe76827.
70%