fix(validation-sets): allow users to ignore sequence increment warning
Metadata
Current evaluation
Merged PR #5545 (cb96b3533), allowing users to ignore validation-set sequence-increment warnings and still submit assertions, fixing the overlooked scenario in #5535.
Resolution: closed resolved
Reason: PR #5545 was approved and merged as commit cb96b3533, making sequence-increment warnings non-blocking so assertions can still be submitted.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
Fixes a scenario I overlooked in #5535.
This allows users to ignore the warning and still submit the assertion.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5545 (cb96b3533), allowing users to ignore validation-set sequence-increment warnings and still submit assertions, fixing the overlooked scenario in #5535. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #5545 (cb96b3533), allowing validation-set sequence warnings to be ignored so assertions can still be submitted. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix enabling users to ignore validation-sets sequence increment warnings while submitting assertions. Approved by two reviewers and passed CI checks prior to merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to allow users to ignore sequence increment warnings and submit assertions. Resolves an oversight from PR #5535. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#5535
(confidence 100%)
PR #5535 introduced the sequence-increment warning whose overlooked submission scenario was fixed here.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5535 feat(validation-sets): warn when the sequence isn't incremented | snapcraft | merged | PR #5535 by mr-cal merged (commit f012b667e): adds a SnapcraftAssertionWarning when a validation set's sequence isn't incremented, plus shared _validate_assertion infrastructure. Fixes #5367. | |
| #5367 Warn on validation set update without incrementing sequence number | snapcraft | closed | Added the validation-set sequence warning in merged PR #5535 (commit f012b667e). | |
| #6423 fix(validation-sets): don't validate new sets | snapcraft | closed | PR #6423 (SNAPCRAFT-1379) fixed edit-validation-sets rejecting brand-new validation sets at sequence 1; approved with no unresolved comments and landed as commit e7b47adb7, stacking on merged PR #6420. | |
| #6420 fix: allow same-sequence validation set revisions | snapcraft | closed | Merged as commit 2989b5f8b via PR #6420 (into hotfix/9.1), restoring the non-blocking sequence warning so edit-validation-sets can publish same-sequence revisions. Fixes #6413. |