fix: allow same-sequence validation set revisions
Metadata
Current evaluation
Merged as commit 2989b5f8b via PR #6420 (into hotfix/9.1), restoring the non-blocking sequence warning so edit-validation-sets can publish same-sequence revisions. Fixes #6413.
Resolution: closed resolved
Reason: PR #6420 was approved (2 reviewers, 0 unresolved comments) and merged as commit 2989b5f8b, closing issue #6413. It restored the #5545 behaviour of treating SnapcraftAssertionWarning as non-fatal, which had regressed into a hard error during the validation-sets service refactor in #6050.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Restore the non-blocking sequence warning so `edit-validation-sets` can publish a new revision without incrementing the sequence.
Fixes #6413
`SnapcraftAssertionWarning` was treated as a hard error after the validation-sets service refactor in #6050, so answering N to “Do you wish to amend?” aborted the operation. This restores the #5545 behavior: the warning is still shown, the user can amend, and if they decline the assertion is signed and submitted.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [x] I've added or updated any relevant documentation.
- [x] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [x] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 2989b5f8b via PR #6420 (into hotfix/9.1), restoring the non-blocking sequence warning so edit-validation-sets can publish same-sequence revisions. Fixes #6413. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 2989b5f8b via PR #6420, restoring non-blocking sequence warnings so edit-validation-sets can publish same-sequence revisions and fixes #6413. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Restores the non-blocking sequence warning for edit-validation-sets, enabling same-sequence validation set revisions. Fixes a regression in #6050 where declining the amendment prompt aborted the operation. Resolves #6413. | |
| qwen/qwen3.6-35b-a3b |
Impact:
55
Quick Win:
47
Staleness:
5
Complexity:
15
Confidence:
85
|
needs review | Fixes regression in edit-validation-sets that blocks same-sequence validation set revisions by restoring non-blocking SnapcraftAssertionWarning behavior. Approved by 2 reviewers, most CI passing. | |
| qwen/qwen3.6-35b-a3b |
Impact:
45
Quick Win:
36
Staleness:
0
Complexity:
20
Confidence:
80
|
needs review | Fixes regression in edit-validation-sets where SnapcraftAssertionWarning was treated as a hard error, blocking same-sequence revision publishing. Approved by 1 reviewer, most CI passing, lint / files failing. | |
| qwen/qwen3.6-35b-a3b |
Impact:
50
Quick Win:
40
Staleness:
0
Complexity:
20
Confidence:
85
|
needs review | Restores non-blocking sequence warning in edit-validation-sets, allowing same-sequence revision publishing. Approved by 1 reviewer, CI passing, rebased onto hotfix/9.1. | |
| qwen/qwen3.6-35b-a3b |
Impact:
50
Quick Win:
38
Staleness:
0
Complexity:
25
Confidence:
75
|
needs review | Fixes regression where SnapcraftAssertionWarning blocks same-sequence validation set revisions; fresh PR awaiting review | |
| qwen/qwen3.6-35b-a3b |
Impact:
55
Quick Win:
36
Staleness:
0
Complexity:
35
Confidence:
75
|
needs review | Fixes regression in edit-validation-sets where SnapcraftAssertionWarning was treated as a hard error, blocking same-sequence revision publishing | |
| qwen/qwen3.6-35b-a3b |
Impact:
50
Quick Win:
40
Staleness:
5
Complexity:
20
Confidence:
70
|
needs review | Fixes regression where edit-validation-sets blocks same-sequence revisions by treating SnapcraftAssertionWarning as a hard error. Restores previous behavior where the warning is non-blocking. |
Update history
| Date | Change |
|---|---|
| closed | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Duplicate Of:
snapcraft#6413
(confidence 98%)
#6413 is the tracking bug this PR explicitly fixes and closes.
-
Related To:
snapcraft#5545
(confidence 95%)
Original PR (cb96b3533) that allowed ignoring the sequence-increment warning; #6420 restores its behaviour.
-
Caused By:
snapcraft#6050
(confidence 93%)
The validation-sets service migration (commit ddfd7b58b) turned SnapcraftAssertionWarning into a hard error, removing the override path.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6413 edit-validation-sets makes it impossible to publish a new revision of an existing sequence (no override) | snapcraft | closed | Regression where edit-validation-sets hard-blocked same-sequence revisions was fixed by merged PR #6420 (commit 2989b5f8b), restoring the non-blocking sequence warning from PR #5545 lost in the #6050 refactor. | |
| #6423 fix(validation-sets): don't validate new sets | snapcraft | closed | PR #6423 (SNAPCRAFT-1379) fixed edit-validation-sets rejecting brand-new validation sets at sequence 1; approved with no unresolved comments and landed as commit e7b47adb7, stacking on merged PR #6420. | |
| #5545 fix(validation-sets): allow users to ignore sequence increment warning | snapcraft | merged | Merged PR #5545 (cb96b3533), allowing users to ignore validation-set sequence-increment warnings and still submit assertions, fixing the overlooked scenario in #5535. |