← Back to issue list

style: ruff 0.12

View original Github issue

Metadata

Project
snapcraft
Number
#5574
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Rebase
Created
Updated
Closed

Current evaluation

Merged Ruff 0.12 compatibility and style updates in commit 94a594fd3 after approval by two reviewers.

Resolution: closed resolved

Reason: PR #5574 was approved and merged as commit 94a594fd3, applying lint compatibility and style changes for Ruff 0.12.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [ ] Have you successfully run `make test`? --- Changes for ruff 0.12.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged Ruff 0.12 compatibility and style updates in commit 94a594fd3 after approval by two reviewers.
stealth/space-bunny-alpha — closed resolved Merged Ruff 0.12 compatibility and style updates in commit 94a594fd3, following approval from two reviewers.
stealth/space-bunny-alpha — closed resolved Merged Ruff 0.12 style and linting updates in commit 94a594fd3; lint passed, though the OSV-scanner check failed.
qwen/qwen3.6-35b-a3b — — Merged after two reviewer approvals. Updates codebase for ruff 0.12 compatibility. CI passed except a non-blocking OSV-scanner failure. Changes affect 8 files with 56 additions and 23 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged maintainer PR updating the codebase to ruff 0.12. Changes passed lint checks and were integrated into the main branch without additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5343 style: ruff 0.11 fixes snapcraft merged Merged Ruff 0.10/0.11 style fixes in #5343, changing two lines in one file, via merge commit ce88542d5.
89%
#165 style: fix linting for ruff 0.12 imagecraft merged Merged #165, incorporating canonical/starbase#408, with a four-file Ruff 0.12 compatibility style update (+7/-7).
83%
#408 style: fix linting for ruff 0.12 starbase merged Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12.
82%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed.
82%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged PR canonical/craft-application#580 (commit 97347705) by lengau applied style-only fixes (+7/-7, 3 files) for new lint failures caused by a Ruff update; approved by 3 reviewers.
82%
#2383 style: update to ruff 0.12 charmcraft merged Merged PR #2383 updated Charmcraft to Ruff 0.12 and applied the associated lint and formatting changes across nine files.
82%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
81%
#2074 style: update to ruff 0.9.0 formatting charmcraft merged Merged PR #2074 in commit af377cd8, updating formatting for Ruff 0.9.0 to address new lint failures.
81%
#199 Update ruff to 0.6 craft-store merged Merged PR #199 updated Ruff to 0.6 across 13 files (+44/-44) after approval by two reviewers.
80%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
80%