← Back to issue list

style: update to ruff 0.9.0 formatting

View original Github issue

Metadata

Project
charmcraft
Number
#2074
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2074 in commit af377cd8, updating formatting for Ruff 0.9.0 to address new lint failures.

Resolution: closed resolved

Reason: PR #2074 was merged as commit af377cd8, changing four files to accommodate Ruff 0.9.0 formatting.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This handles the cases where lint starts failing with ruff 0.9.0.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2074 in commit af377cd8, updating formatting for Ruff 0.9.0 to address new lint failures.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#2074 via commit af377cd8, updating four files to prevent lint failures with Ruff 0.9.0. One suggested change was deferred to upstream starbase.
qwen/qwen3.6-35b-a3b — — Merged to align code formatting with ruff 0.9.0 linting rules. Approved by two reviewers and passed CI. One change was noted for upstreaming to starbase instead of applying it locally.
qwen3.6-35b-a3b-mtp-q6 — — Merged to align code formatting with ruff 0.9.0 and resolve lint failures. One craft-parts adjustment was deferred for upstreaming to starbase rather than included here.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#969 (confidence 90%)

    The maintainer noted that the craft-parts-specific change should be upstreamed via starbase; #969 separately merged Ruff 0.9 fixes.

Related issues

Issue Project State Summary Similarity
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
86%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed.
86%
#319 style: update linting configuration for ruff 0.9 starbase merged Ruff 0.9 lint configuration update merged into main via commit 45ab05b (PR #319). The unrelated git_describe_command suggestion was deferred to PR #321.
86%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
85%
#969 style: fix linting issues for ruff 0.9 craft-parts merged Merged as commit f1427855: small Ruff 0.9 lint fixes (+2/-1) across 2 files, following the ruff-pre-commit hook bump to the 0.9.x series.
85%
#2383 style: update to ruff 0.12 charmcraft merged Merged PR #2383 updated Charmcraft to Ruff 0.12 and applied the associated lint and formatting changes across nine files.
85%
#408 style: fix linting for ruff 0.12 starbase merged Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12.
85%
#29 style(lint): fix ruff 0.6.0 linting errors craft-platforms merged Merged PR #29 as commit 399c4e0, fixing Ruff 0.6.0 lint errors and switching the pre-commit Ruff hook to rolling versions.
82%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804.
82%
#1825 style(lint): fix ruff 0.6.0 linting errors charmcraft merged Merged PR #1825 as commit 7aa2965b, applying Ruff 0.6.0 autofixes across 31 files to resolve linting errors.
82%