← Back to issue list

fix(ROS): ROS snap content sharing now supports non upstream packages

View original Github issue

Metadata

Project
snapcraft
Number
#6120
Type
pull request
State
closed
Author
Guillaumebeuzeboc
Labels
—
Created
Updated
Closed

Current evaluation

Superseded by PR #6139 targeting hotfix/8.14. Fixes ROS 2 plugin to support non-upstream packages and replaces deprecated rospack with ros2 pkg for an immediate release.

Suggested action: —

No scores available.

Issue body

The current ROS 2 plugin was not capable of handling ROS 2 packages dependencies from the ROS content sharing not available upstream. Additionally, I realized we've been using `rospack`, a deprecated ROS package instead of `ros2 pkg`. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Superseded by PR #6139 targeting hotfix/8.14. Fixes ROS 2 plugin to support non-upstream packages and replaces deprecated rospack with ros2 pkg for an immediate release.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #6139 targeting hotfix/8.14 for a quicker release. The original PR fixed ROS 2 plugin dependency handling for non-upstream packages and replaced deprecated rospack with ros2 pkg.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #6139 targeting the hotfix/8.14 branch. The original pull request fixed ROS 2 content sharing for non-upstream packages and replaced the deprecated rospack tool with ros2 pkg.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6139 fix: ros content sharing non upstream package 8 14 snapcraft merged Merged a fix updating the ROS 2 plugin to handle non-upstream package dependencies and replace deprecated rospack with ros2 pkg. The changes supersede PR #6120, incorporate requested unit tests, and passed review and CI validation.
87%