fix(ROS): ROS snap content sharing now supports non upstream packages
Metadata
Current evaluation
PR was approved but closed unmerged; author retargeted the ROS content-sharing fix (non-upstream deps, rospack -> ros2 pkg) to PR #6139, merged as commit 0833c6d21 into hotfix/8.14 for Snapcraft 8.
Resolution: closed superseded
Reason: Maintainer asked for the fix to land in the 8.14 hotfix rather than main, and the author confirmed in a closing comment (2026-03-30) that he opened #6139, which was merged in commit 0833c6d21 with the same changes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The current ROS 2 plugin was not capable of handling ROS 2 packages dependencies from the ROS content sharing not available upstream.
Additionally, I realized we've been using `rospack`, a deprecated ROS package instead of `ros2 pkg`.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [x] I've added or updated any relevant documentation.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR was approved but closed unmerged; author retargeted the ROS content-sharing fix (non-upstream deps, rospack -> ros2 pkg) to PR #6139, merged as commit 0833c6d21 into hotfix/8.14 for Snapcraft 8. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by merged PR canonical/snapcraft#6139, which added non-upstream ROS content-sharing support and replaced deprecated rospack with ros2 pkg in hotfix/8.14. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #6139 targeting hotfix/8.14. Fixes ROS 2 plugin to support non-upstream packages and replaces deprecated rospack with ros2 pkg for an immediate release. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by PR #6139 targeting hotfix/8.14 for a quicker release. The original PR fixed ROS 2 plugin dependency handling for non-upstream packages and replaced deprecated rospack with ros2 pkg. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#6139
(confidence 96%)
Hotfix/8.14 version of this PR; merged in commit 0833c6d21 and added non-upstream ROS content-sharing support plus replacement of deprecated rospack with ros2 pkg.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6139 fix: ros content sharing non upstream package 8 14 | snapcraft | merged | Merged in commit 0833c6d21, fixing ROS 2 content sharing for non-upstream dependencies and replacing deprecated rospack with ros2 pkg; supersedes #6120. | |
| #6138 Fix/ros content sharing non upstream package 8 14 | snapcraft | closed | PR #6138 was closed unmerged and superseded by #6139, which fixed ROS 2 content sharing for non-upstream packages and replaced deprecated rospack with ros2 pkg. |