Fix/ros content sharing non upstream package 8 14
Metadata
Current evaluation
PR #6138 was closed unmerged and superseded by #6139, which fixed ROS 2 content sharing for non-upstream packages and replaced deprecated rospack with ros2 pkg.
Resolution: closed superseded
Reason: Merged PR canonical/snapcraft#6139 delivered the fix in commit 0833c6d21, so the duplicate follow-up PR #6138 was closed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Describe your changes.
---
- [X] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [X] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [X] I've successfully run `make lint && make test`.
- [X] I've added or updated any relevant documentation.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #6138 was closed unmerged and superseded by #6139, which fixed ROS 2 content sharing for non-upstream packages and replaced deprecated rospack with ros2 pkg. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by merged PR #6139 (commit 0833c6d21), adding ROS content sharing for non-upstream packages and replacing rospack with ros2 pkg. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by merged PR #6139, which fixed ROS 2 content sharing for non-upstream packages and replaced deprecated rospack with ros2 pkg. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by merged PR canonical/snapcraft#6139 (commit 0833c6d21), which added ROS 2 content-sharing support for non-upstream packages on hotfix/8.14. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. CI checks failed on conventional commit policy and integration tests. Zero reviewer comments and 113 days of inactivity resulted in the changes being abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without being merged. The fix for ROS content sharing in non-upstream packages was abandoned, with no comments or resolution documented. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#6139
(confidence 100%)
Merged PR #6139 implemented the ROS content-sharing fix in commit 0833c6d21.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6139 fix: ros content sharing non upstream package 8 14 | snapcraft | merged | Merged in commit 0833c6d21, fixing ROS 2 content sharing for non-upstream dependencies and replacing deprecated rospack with ros2 pkg; supersedes #6120. | |
| #6120 fix(ROS): ROS snap content sharing now supports non upstream packages | snapcraft | closed | PR was approved but closed unmerged; author retargeted the ROS content-sharing fix (non-upstream deps, rospack -> ros2 pkg) to PR #6139, merged as commit 0833c6d21 into hotfix/8.14 for Snapcraft 8. | |
| #4180 Feature/ros content sharing | snapcraft | closed | Closed unmerged after inactivity; ROS content-sharing support was delivered by merged PR #4221 in commit 374c5c6a6. |