← Back to issue list

build: fix docs-install target

View original Github issue

Metadata

Project
snapcraft
Number
#6133
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #6133 as commit f6f0bd918, fixing the docs-install Make target that was breaking documentation builds after dependency setup.

Resolution: closed resolved

Reason: PR #6133 was approved and merged as commit f6f0bd918. Its two-file, two-line Makefile correction fixes the docs-install target and explicitly resolves issue #6132.

Evaluated by: mr-cal-bot

No scores available.

Issue body

If approved, I'll upstream in starbase. Fixes #6132 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #6133 as commit f6f0bd918, fixing the docs-install Make target that was breaking documentation builds after dependency setup.
stealth/space-bunny-alpha — closed resolved Merged PR #6133 as commit f6f0bd918, fixing the docs-install target so dependency setup no longer disrupts linting or mypy; it resolves #6132.
stealth/space-bunny-alpha — closed resolved Merged PR #6133 as f6f0bd918, fixing the docs-install target so dependency setup no longer breaks linting or mypy and closing #6132.
qwen/qwen3.6-35b-a3b — — Merged a fix for the docs-install Makefile target that resolved redundant dependency installation. The change removes an extra uv sync call, ensuring docs targets work after make setup. Approved by reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for the docs-install Makefile target. Removed redundant uv sync calls and established that setup commands must precede docs builds. Addressed workflow asymmetry concerns. Approved after verifying dev and CI compatibility.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#6132 (confidence 100%)

    The PR body explicitly states that it fixes #6132.

Related issues

Issue Project State Summary Similarity
#525 build: fix docs-install target starbase merged Merged PR #525 as commit b434201, fixing docs-install so make lint keeps the correct development dependencies installed throughout linting.
87%
#563 fix(build): collapse docs-install logs under parent targets starbase merged Merged PR #563 in commit 544b986, nesting docs-install output under parent documentation targets to remove separate, uncollapsible install logs from CI.
77%
#513 build(docs): fix double build with docs-lint starbase merged Merged #513 in commit 1107517, changing docs-lint to install dependencies without a full docs build and fixing #512's redundant double build.
74%
#1159 docs: use correct target to generate docs. snapcraft merged Merged PR #1159 as commit dad5cad24, correcting the documentation generation target with a one-line change.
73%
#258 docs: update readme and template, fix build error starbase merged Merged PR #258 in commit 7d2790e, improving README and docs-preparation guidance and disabling PDF/EPUB generation to restore the documentation build.
72%
#54 fix(docs): make readthedocs build correctly craft-platforms merged Merged PR #54 via commit 16406ff, correcting the Read the Docs configuration so the documentation builds successfully.
72%
#512 docs: linting builds the docs twice starbase closed Fixed by merged PR #513, which changed docs-lint to depend on docs-install instead of docs, eliminating the duplicate documentation build.
71%
#1070 build(docs)!: add dependency starter pack 1.5 craft-application merged Merged PR #1070 added dependency starter pack 1.5 to fix docs-only PR builds, landing as commit 691eec7e with all CI checks passing.
70%