build: fix docs-install target
Metadata
Current evaluation
Merged a fix for the docs-install Makefile target that resolved redundant dependency installation. The change removes an extra uv sync call, ensuring docs targets work after make setup. Approved by reviewers and passed CI.
Suggested action: —
No scores available.
Issue body
If approved, I'll upstream in starbase.
Fixes #6132
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for the docs-install Makefile target that resolved redundant dependency installation. The change removes an extra uv sync call, ensuring docs targets work after make setup. Approved by reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for the docs-install Makefile target. Removed redundant uv sync calls and established that setup commands must precede docs builds. Addressed workflow asymmetry concerns. Approved after verifying dev and CI compatibility. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for the docs-install target that removes redundant uv sync calls. Requires make setup or make setup-docs before docs targets, resolving dependency conflicts and ensuring consistent behavior across dev and CI workflows. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #525 build: fix docs-install target | starbase | merged | Merged a build fix optimizing the docs-install target by retaining dev dependencies throughout make lint execution. Approved by reviewers and passed CI checks, yielding a faster and more correct linting process. | |
| #563 fix(build): collapse docs-install logs under parent targets | starbase | merged | Merged a Makefile update that collapses docs-install log output under parent targets to prevent CI log clutter. Approved by reviewers, passed all CI checks, and resolves the logging issue. | |
| #419 fix: remove conflicting syncs during setup | starbase | merged | Merged to fix conflicting uv sync calls during setup. Introduces intermediate _setup-* targets to install requirements before syncing. Approved by two reviewers, passed all CI checks, and successfully merged. | |
| #594 build: run docs-clean as part of clean target | starbase | merged | Merged a one-line Makefile update adding docs-clean to the clean target. This resolves CI lint failures from stale documentation styles by ensuring make clean removes generated artifacts. Approved by two reviewers and passed all CI checks. | |
| #367 fix(build): install system packages when running `make setup` | craft-cli | merged | Merged a build fix installing system packages during make setup. Approved by two reviewers with all CI checks passing. The single-file change (+19/-10 lines) ensures build dependencies are correctly provisioned. | |
| #566 build(docs): override docs-clean target | starbase | merged | Merged. Overrides the docs-clean Makefile target to prevent accidental virtual environment deletion and resolve ambiguous test command failures during documentation cleanup. Approved by reviewers and passed all CI checks. | |
| #512 docs: linting builds the docs twice | starbase | closed | Closed. Implemented the suggested fix by changing the docs-lint target dependency from docs to docs-install in common.mk, preventing redundant documentation builds. | |
| #418 fix: install system packages during setup | starbase | merged | Merged after approval and passing CI checks. The update configures make setup to run all setup targets, ensuring system packages are installed. A reviewer flagged potential dependency conflicts, but the changes were successfully integrated. | |
| #341 fix(make): depend on build deps during setup | starbase | merged | Merged after reviewer approval and passing CI. The change updates the Makefile to correctly declare build dependencies during the setup phase, modifying a single line. | |
| #330 build!: switch from using extras to dependency groups | starbase | merged | Merged a breaking change replacing project extras with standard dependency groups. Updated the ReadTheDocs build to use uv for faster execution and fixed the PR template. Approved by a maintainer after passing CI. |