build: fix docs-install target
Metadata
Current evaluation
Merged PR #525 as commit b434201, fixing docs-install so make lint keeps the correct development dependencies installed throughout linting.
Resolution: closed resolved
Reason: The two-line Makefile fix was approved and merged in commit b434201. It prevents lint steps from repeatedly changing development dependencies.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Upstream of https://github.com/canonical/snapcraft/pull/6133.
Starbase wasn't broken like Snapcraft was, but this fix makes Starbase more correct and faster. Previously, `make lint` would uninstall and install dev deps at different points within `make lint`. Now, it keeps the correct deps installed throughout `make lint`.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #525 as commit b434201, fixing docs-install so make lint keeps the correct development dependencies installed throughout linting. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged Starbase #525 via b434201, fixing docs-install so make lint keeps the correct dev dependencies installed throughout linting. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a build fix optimizing the docs-install target by retaining dev dependencies throughout make lint execution. Approved by reviewers and passed CI checks, yielding a faster and more correct linting process. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged build fix for the docs-install target. Ensures dev dependencies remain installed throughout make lint, improving correctness and execution speed. Resolves upstream dependency handling issues in the Starbase build system. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#6133
(confidence 100%)
The merged change was explicitly described as upstream from Snapcraft PR #6133.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6133 build: fix docs-install target | snapcraft | merged | Merged PR #6133 as commit f6f0bd918, fixing the docs-install Make target that was breaking documentation builds after dependency setup. | |
| #512 docs: linting builds the docs twice | starbase | closed | Fixed by merged PR #513, which changed docs-lint to depend on docs-install instead of docs, eliminating the duplicate documentation build. | |
| #513 build(docs): fix double build with docs-lint | starbase | merged | Merged #513 in commit 1107517, changing docs-lint to install dependencies without a full docs build and fixing #512's redundant double build. | |
| #563 fix(build): collapse docs-install logs under parent targets | starbase | merged | Merged PR #563 in commit 544b986, nesting docs-install output under parent documentation targets to remove separate, uncollapsible install logs from CI. | |
| #1159 docs: use correct target to generate docs. | snapcraft | merged | Merged PR #1159 as commit dad5cad24, correcting the documentation generation target with a one-line change. | |
| #594 build: run docs-clean as part of clean target | starbase | merged | Merged PR canonical/starbase#594 makes the top-level `clean` target depend on the docs `docs-clean` target, so stale docs/_dev/styles/ no longer cause CI-only `make lint-docs` failures. One-line Makefile change, approved and merged. |