build: fix docs-install target
Metadata
Current evaluation
Merged a build fix optimizing the docs-install target by retaining dev dependencies throughout make lint execution. Approved by reviewers and passed CI checks, yielding a faster and more correct linting process.
Suggested action: —
No scores available.
Issue body
Upstream of https://github.com/canonical/snapcraft/pull/6133.
Starbase wasn't broken like Snapcraft was, but this fix makes Starbase more correct and faster. Previously, `make lint` would uninstall and install dev deps at different points within `make lint`. Now, it keeps the correct deps installed throughout `make lint`.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a build fix optimizing the docs-install target by retaining dev dependencies throughout make lint execution. Approved by reviewers and passed CI checks, yielding a faster and more correct linting process. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged build fix for the docs-install target. Ensures dev dependencies remain installed throughout make lint, improving correctness and execution speed. Resolves upstream dependency handling issues in the Starbase build system. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6133 build: fix docs-install target | snapcraft | merged | Merged a fix for the docs-install Makefile target that resolved redundant dependency installation. The change removes an extra uv sync call, ensuring docs targets work after make setup. Approved by reviewers and passed CI. | |
| #594 build: run docs-clean as part of clean target | starbase | merged | Merged a one-line Makefile update adding docs-clean to the clean target. This resolves CI lint failures from stale documentation styles by ensuring make clean removes generated artifacts. Approved by two reviewers and passed all CI checks. | |
| #563 fix(build): collapse docs-install logs under parent targets | starbase | merged | Merged a Makefile update that collapses docs-install log output under parent targets to prevent CI log clutter. Approved by reviewers, passed all CI checks, and resolves the logging issue. | |
| #512 docs: linting builds the docs twice | starbase | closed | Closed. Implemented the suggested fix by changing the docs-lint target dependency from docs to docs-install in common.mk, preventing redundant documentation builds. | |
| #513 build(docs): fix double build with docs-lint | starbase | merged | Merged a one-line fix resolving a double build issue during docs-lint by correcting a mistaken assumption about Sphinx's linter requirements. Approved by two reviewers, passed CI, and closed issue #512. | |
| #508 fix: quieter docs-lint in CI | starbase | merged | Merged a fix grouping CI docs-lint prerequisites to reduce log verbosity. Approved by three reviewers with all checks passing. The change modifies one workflow file, adding 18 lines to streamline continuous integration output. | |
| #493 fix(build): false lint errors | starbase | merged | Merged a fix for false lint errors by ignoring the .sphinx directory and splitting sphinx-lint arguments. All CI checks passed and reviewers approved the changes. | |
| #367 fix(build): install system packages when running `make setup` | craft-cli | merged | Merged a build fix installing system packages during make setup. Approved by two reviewers with all CI checks passing. The single-file change (+19/-10 lines) ensures build dependencies are correctly provisioned. | |
| #2137 fix(build): fix build dependencies and CI | charmcraft | merged | Merged by maintainer lengau after approval from two reviewers. Resolved build dependency and CI configuration issues across three files, adding 51 lines and removing 13. | |
| #551 docs: resolve `docs-lint` issues | starbase | merged | Merged after resolving documentation linting issues. Excluded docs/_dev/ from Sphinx linting and updated link checker timeout. Passed all CI checks, received approval, and was successfully integrated. |