← Back to issue list

build(docs): fix double build with docs-lint

View original Github issue

Metadata

Project
starbase
Number
#513
Type
pull request
State
merged
Author
medubelko
Labels
Created
Updated
Closed

Current evaluation

Merged a one-line fix resolving a double build issue during docs-lint by correcting a mistaken assumption about Sphinx's linter requirements. Approved by two reviewers, passed CI, and closed issue #512.

Suggested action:

No scores available.

Issue body

We mistakenly thought that Sphinx's linter needed a complete build. Resolves #512. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a one-line fix resolving a double build issue during docs-lint by correcting a mistaken assumption about Sphinx's linter requirements. Approved by two reviewers, passed CI, and closed issue #512.
qwen3.6-35b-a3b-mtp-q6 Merged fix for docs-lint double build issue. Corrected the assumption that Sphinx requires a full build before linting, resolving issue #512.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#453 build(docs): remove line length check from linter starbase merged Merged a change removing the line length check from the documentation linter. Approved by two reviewers, passed all CI checks, and updated a single line.
79%
#551 docs: resolve `docs-lint` issues starbase merged Merged after resolving documentation linting issues. Excluded docs/_dev/ from Sphinx linting and updated link checker timeout. Passed all CI checks, received approval, and was successfully integrated.
79%
#512 docs: linting builds the docs twice starbase closed Closed. Implemented the suggested fix by changing the docs-lint target dependency from docs to docs-install in common.mk, preventing redundant documentation builds.
78%
#5832 build(docs): remove line length check from linter snapcraft merged Merged after approval by two reviewers. Removes the line length check from the documentation linter. All required CI checks passed, with a single line modification applied.
77%
#493 fix(build): false lint errors starbase merged Merged a fix for false lint errors by ignoring the .sphinx directory and splitting sphinx-lint arguments. All CI checks passed and reviewers approved the changes.
77%
#525 build: fix docs-install target starbase merged Merged a build fix optimizing the docs-install target by retaining dev dependencies throughout make lint execution. Approved by reviewers and passed CI checks, yielding a faster and more correct linting process.
76%
#498 fix(docs): fix docs for canonical-sphinx 0.2 craft-application merged Merged documentation fix replacing the diataxis grid with a list-table to resolve build failures from the canonical-sphinx 0.2 update. Approved by two reviewers and passed CI.
75%
#4358 style(docs): fix linter errors for auto-generated commands snapcraft merged Merged via rebase-and-merge after two approvals and passing CI. Fixed linter errors in auto-generated documentation by ensuring docs are built prior to linting. Modified 5 files with negligible coverage impact.
75%
#2466 build(docs): remove line length check from linter charmcraft merged Merged a one-line change removing the line length check from the documentation linter. Approved by two reviewers. Accepted after passing primary CI checks, despite initial failures on macOS and Ubuntu 20.04.
75%
#900 build(docs): update build, add sphinx sitemap, update site links rockcraft merged Merged after two approvals and passing all CI checks. Updates docs build config, switches Sphinx to dirhtml for sitemap generation, adds a sitemap, updates site links, and standardizes tooling across five files.
74%