← Back to issue list

Added maven-targets to maven plugin.

View original Github issue

Metadata

Project
snapcraft
Number
#624
Type
pull request
State
closed
Author
ZenHarbinger
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after the author found Maven target directories included unwanted files and planned to redesign the feature; no resolving PR or commit landed.

Resolution: closed stale

Reason: The author withdrew the approach in the 2016-07-02 comment, stating that copying target directories carried baggage and would be reconsidered in a resubmission. The proposal received no reviews or CI and was later closed unmerged.

Evaluated by: mr-cal-bot

No scores available.

Issue body

maven-targets is an object that allows a source-destination pair. The default value is `target: jar` This modification is useful if using a composite pom.xml that has many sub projects. The parent pom.xml won't generate a 'target' directory. This allows using multiple outputs of the parent pom in the snap. Ex: ``` yml parts: algolink-mvn: plugin: maven maven-targets: algolink-gui/target: algolink-gui algolink-cli/target: algolink-cli source: . ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed unmerged after the author found Maven target directories included unwanted files and planned to redesign the feature; no resolving PR or commit landed.
stealth/space-bunny-alpha — closed stale Closed unmerged after the author found that copying target directories included unwanted baggage; they planned to revise the maven-targets approach and resubmit.
qwen/qwen3.6-35b-a3b — — Closed and abandoned by the author after identifying baggage in copying the target directory. The contributor plans to revise the maven-targets implementation for composite pom.xml projects and resubmit.
qwen3.6-35b-a3b-mtp-q6 — — Proposed maven-targets support was closed without merging. The author withdrew the changes, citing baggage from copying target directories, and planned to revise and resubmit later.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#626 Added new maven-targets option to maven plugin. snapcraft closed Closed unmerged after no review; equivalent maven-targets support was later merged in #650 via commit 710401610.
86%
#627 Added new maven-targets option to maven plugin. snapcraft closed Closed unmerged; Maven target support was rebased and merged through canonical/snapcraft#650 in commit 710401610.
83%
#625 Added mavent-targets for when building composite maven projects in sn… snapcraft closed Closed unmerged after composite Maven support was reworked in #638 and delivered by merged PR #650 via commit 710401610.
76%
#827 Support setting build targets in the maven plugin. Make the maven plu… snapcraft closed Closed as stale after conflicts and prolonged inactivity; equivalent Maven target support had already landed in #650 via commit 710401610.
71%
#650 feature/maven-targets w/ re-based maven.py snapcraft merged Merged rebased Maven-target support with tests, resolving Launchpad bug #1599987 in commit 710401610.
70%
#1599987 Add maven-targets to maven plugin snapcraft (launchpad) closed Maven target support was implemented and merged in snapcraft PR #650 (commit 710401610), enabling composite projects with module-specific target directories.
70%