← Back to issue list

Added new maven-targets option to maven plugin.

View original Github issue

Metadata

Project
snapcraft
Number
#626
Type
pull request
State
closed
Author
ZenHarbinger
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after no review; equivalent maven-targets support was later merged in #650 via commit 710401610.

Resolution: closed superseded

Reason: PR #626 remained unreviewed and was closed unmerged. Its functionality was subsequently implemented and merged by PR #650 in commit 710401610.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Composite maven projects do not build to 'target'. This update allows the user to specify the child target to copy. ``` yml parts: algolink-mvn: plugin: maven source: . maven-targets: - algolink-gui - algolink-cli ``` By default, the basedir/target directory is searched, otherwise it uses the 'target' directory of each specified value. The installdir for each child project is the name of the child project. If no values are specified, it reverts to the default of 'jar' or 'war' depending on the target type of the project.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged after no review; equivalent maven-targets support was later merged in #650 via commit 710401610.
stealth/space-bunny-alpha — closed superseded PR #626 was closed unmerged after going unreviewed; equivalent maven-targets support later landed via merged #650 (commit 710401610).
stealth/space-bunny-alpha — closed superseded PR #626’s maven-targets patch was closed unmerged after remaining unreviewed; equivalent support later landed in #650 via commit 710401610.
qwen/qwen3.6-35b-a3b — — Abandoned without merging. The update added a maven-targets option to specify child target directories for composite Maven projects. It remained pending review and was closed due to lack of admin verification.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merge. Admin verification was requested but never completed, leaving the proposed maven-targets configuration option abandoned.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#650 (confidence 99%)

    Merged rebased implementation of Maven target support, including tests.

Related issues

Issue Project State Summary Similarity
#627 Added new maven-targets option to maven plugin. snapcraft closed Closed unmerged; Maven target support was rebased and merged through canonical/snapcraft#650 in commit 710401610.
91%
#624 Added maven-targets to maven plugin. snapcraft closed Closed unmerged after the author found Maven target directories included unwanted files and planned to redesign the feature; no resolving PR or commit landed.
86%
#625 Added mavent-targets for when building composite maven projects in sn… snapcraft closed Closed unmerged after composite Maven support was reworked in #638 and delivered by merged PR #650 via commit 710401610.
79%
#827 Support setting build targets in the maven plugin. Make the maven plu… snapcraft closed Closed as stale after conflicts and prolonged inactivity; equivalent Maven target support had already landed in #650 via commit 710401610.
74%
#650 feature/maven-targets w/ re-based maven.py snapcraft merged Merged rebased Maven-target support with tests, resolving Launchpad bug #1599987 in commit 710401610.
72%
#1599987 Add maven-targets to maven plugin snapcraft (launchpad) closed Maven target support was implemented and merged in snapcraft PR #650 (commit 710401610), enabling composite projects with module-specific target directories.
72%
#1651339 Add keyword maven-target to help of maven plugin snapcraft (launchpad) closed Request to document maven-target keyword in plugin help was closed as stale since the keyword no longer exists.
71%