← Back to issue list

feature/maven-targets w/ re-based maven.py

View original Github issue

Metadata

Project
snapcraft
Number
#650
Type
pull request
State
merged
Author
ZenHarbinger
Labels
—
Created
Updated
Closed

Current evaluation

Merged rebased Maven-target support with tests, resolving Launchpad bug #1599987 in commit 710401610.

Resolution: closed resolved

Reason: PR #650 was merged as commit 710401610, delivering the rebased implementation from #638 and adding composite Maven-target support.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Re-based maven plugin + test. Bug Report: https://bugs.launchpad.net/snapcraft/+bug/1599987 Original PR: https://github.com/snapcore/snapcraft/pull/638

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged rebased Maven-target support with tests, resolving Launchpad bug #1599987 in commit 710401610.
stealth/space-bunny-alpha — closed resolved Merged rebased Maven targets support in #650 (commit 710401610), addressing Launchpad bug #1599987 and following the earlier #638 implementation.
qwen/qwen3.6-35b-a3b — — Merged after rebasing the maven plugin and test suite. CI failures were resolved by unmocking glob and fixing test errors. Admin verification confirmed readiness prior to integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged ZenHarbinger's re-based maven plugin and tests. After CI failures, the author pushed a fix unmocking glob, passing review and successfully merging the feature.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#638 (confidence 100%)

    Original Maven-target PR whose rebased implementation was merged through #650.

  • Related To: snapcraft (launchpad)#1599987 (confidence 100%)

    Launchpad bug requesting Maven-target support, addressed by the merged change.

Related issues

Issue Project State Summary Similarity
#627 Added new maven-targets option to maven plugin. snapcraft closed Closed unmerged; Maven target support was rebased and merged through canonical/snapcraft#650 in commit 710401610.
74%
#626 Added new maven-targets option to maven plugin. snapcraft closed Closed unmerged after no review; equivalent maven-targets support was later merged in #650 via commit 710401610.
72%
#625 Added mavent-targets for when building composite maven projects in sn… snapcraft closed Closed unmerged after composite Maven support was reworked in #638 and delivered by merged PR #650 via commit 710401610.
72%
#651 Re-based feature/gradle-plugin snapcraft merged Merged the rebased Gradle plugin in commit 48cb3adc6, replacing #646 and implementing Launchpad bug 1600492.
71%
#624 Added maven-targets to maven plugin. snapcraft closed Closed unmerged after the author found Maven target directories included unwanted files and planned to redesign the feature; no resolving PR or commit landed.
70%