← Back to issue list

feature/maven-targets w/ re-based maven.py

View original Github issue

Metadata

Project
snapcraft
Number
#650
Type
pull request
State
merged
Author
ZenHarbinger
Labels
Created
Updated
Closed

Current evaluation

Merged after rebasing the maven plugin and test suite. CI failures were resolved by unmocking glob and fixing test errors. Admin verification confirmed readiness prior to integration.

Suggested action:

No scores available.

Issue body

Re-based maven plugin + test. Bug Report: https://bugs.launchpad.net/snapcraft/+bug/1599987 Original PR: https://github.com/snapcore/snapcraft/pull/638

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after rebasing the maven plugin and test suite. CI failures were resolved by unmocking glob and fixing test errors. Admin verification confirmed readiness prior to integration.
qwen3.6-35b-a3b-mtp-q6 Merged ZenHarbinger's re-based maven plugin and tests. After CI failures, the author pushed a fix unmocking glob, passing review and successfully merging the feature.
qwen3.6-35b-a3b-mtp-q6 Merged after the author rebased the maven plugin and tests, fixed CI failures caused by glob mocking, and received maintainer approval.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#357 tests: Ensure maven test sets environment craft-parts merged Merged changes to ensure the Maven test runs independently by properly setting its environment. Updated init.py to clear cached functions between integration tests. Approved by one reviewer, passed CI, and modified two files with 27 additions.
70%