← Back to issue list

style: fix gnome extension typing

View original Github issue

Metadata

Project
snapcraft
Number
#6260
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for GNOME extension typing errors caught by ty. Approved by two reviewers and passing CI, the change resolves the type checking failure in a single file.

Suggested action:

No scores available.

Issue body

Fixes a new error caught by `ty`. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for GNOME extension typing errors caught by ty. Approved by two reviewers and passing CI, the change resolves the type checking failure in a single file.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for a gnome extension typing error caught by the ty type checker. The changes passed linting and testing, resolving the static analysis issue.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4798 extension: fix issues and depreciated vars in gnome extension snapcraft merged Merged changes fixing issues and deprecated variables in the GNOME extension. Approved by two reviewers, passed all CI checks, and modified two files with six additions and six deletions.
75%
#407 style(types): enable type checking with ty craft-cli merged Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements.
72%