style: suppress ty warning
Metadata
Current evaluation
Merged a one-line change to suppress a ty 0.0.79 false positive on user_files["shadow"]. Approved by one reviewer and passed CI checks.
Suggested action: —
No scores available.
Issue body
ty 0.0.79 thinks `user_files["shadow"]` is always `""`, but there is a block of code before hand that as far as I can tell can alter the dict value.
---
- [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md).
- [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a one-line change to suppress a ty 0.0.79 false positive on user_files["shadow"]. Approved by one reviewer and passed CI checks. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #242 style: fix ty linting error | craft-platforms | merged | Merged a single-file change fixing a ty linting error. Approved by one reviewer and passed CI checks. The one-line modification resolves the style violation. | |
| #421 style: ty | craft-cli | merged | Merged to update the ty tool, unblocking work on snapcraft issue #5673. Approved by two reviewers with all CI checks passing. Changes affect two files (+10/-5 lines) and create follow-up issue #420. | |
| #6280 style: ty 0.0.44 | snapcraft | merged | Merged update to ty version 0.0.44. Approved by two reviewers and passed core CI checks. Unrelated lint failures and integration timeouts did not block the merge. | |
| #335 fix(lint): suppress ty | imagecraft | merged | Merged after two approvals and passing CI checks. Fixes a lint failure by suppressing the ty rule across two files, modifying three lines of code. | |
| #2726 style: switch type checking to ty | charmcraft | merged | Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files. | |
| #6015 style: fix additional ty warnings | snapcraft | merged | Merged pull request resolving additional ty linter warnings for unsupported operators and non-subscriptable types. Approved by two reviewers, passed CI checks, and implemented a minimal two-file fix related to #5970. | |
| #1698 style: ty | craft-parts | merged | Enables ty as a lint target and fixes its warnings across 37 files (+69/-65). Fresh maintainer-authored PR, CI passing with some slow-test jobs pending, awaiting first review. | |
| #434 style: silence ty warnings | craft-cli | merged | Merged to silence ty linter warnings, aligning with existing linter configurations. Approved by two reviewers and passed CI checks. The change modifies two files with five additions and five deletions. | |
| #6247 style: go all-in on ty | snapcraft | merged | Merged after approval by two reviewers. The change adopts the ty linter for comprehensive typo detection, resolving issue #6007. It updated 47 files, reducing 370 lines and adding 139. | |
| #6266 style: ignore configparser shadowing | snapcraft | merged | Merged a change to suppress a Ty linter warning about configparser shadowing. Added a style ignore directive to avoid unnecessary subclassing. Approved by two reviewers and passed CI checks. |