← Back to issue list

chore(store)!: remove candid login

View original Github issue

Metadata

Project
snapcraft
Number
#6288
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged after two reviewer approvals and passing CI checks. The change removes the candid login method from Snapcraft (SNAPCRAFT-1254), updating seven files with a net reduction of 27 lines.

Suggested action:

No scores available.

Issue body

Removes the candid login method from Snapcraft. (SNAPCRAFT-1254) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two reviewer approvals and passing CI checks. The change removes the candid login method from Snapcraft (SNAPCRAFT-1254), updating seven files with a net reduction of 27 lines.
qwen3.6-35b-a3b-mtp-q6 Merged maintainer mr-cal's change that removes the candid login method from Snapcraft, resolving SNAPCRAFT-1254. The pull request passed lint and test checks before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#539 chore: log snap installation method craft-application merged Merged. Added a debug log message to clarify why the snap installation method was selected. Approved by two reviewers, the change was integrated as a minor, fly-by contribution without formal issue tracking.
74%
#221 chore(merge): 2.6.2 into main craft-store merged Merged into main after passing CI and receiving two approvals. Backports a fix from craft-store PR #175 to resolve snapcraft issue #5077, addressing a regression from the craft-store 3.0 upgrade. A follow-up craft-store release is planned.
73%
#1078 chore!: remove deprecated APIs craft-application merged Merged, removing 8 deprecated APIs from craft-applications to resolve issue #1063. Approved by two reviewers with all CI checks passing. Locally verified with snapcraft, reducing code by 345 lines across 11 files.
72%
#6241 chore: remove snapcraft_legacy snapcraft merged Merged removal of the snapcraft_legacy module, old specs folder, and dependencies after verifying no remaining entry points. Approved by two reviewers; noted unrelated integration test failures.
72%
#2682 chore: delete some dead code charmcraft open Removes 19 lines of dead code in one file, a follow-up to #2681 (remote-build project name fix). Approved by a maintainer, CI mostly green with a few failing/pending snap tests.
71%
#1357 chore: remove unused docs requirements file craft-parts merged Merged removal of an unused docs requirements file to eliminate Renovate PR noise. Approved by two reviewers with all CI checks passing, following a prior cleanup in the Snapcraft project.
71%
#5821 chore(legacy): remove script entry point snapcraft merged Merged removal of a legacy script entry point causing user confusion. Approved by two reviewers, passed CI checks, and deleted a single line in one file to clean up the codebase.
70%