← Back to issue list

feat(store): error on candid creds

View original Github issue

Metadata

Project
snapcraft
Number
#6417
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged as 7ed8b939e: adds user-friendly errors and recovery advice for obsolete Candid store credentials, closing #6414 (SNAPCRAFT-1381). Lint failure was an unrelated 403 fetching an external KDE link.

Resolution: closed resolved

Reason: PR #6417 was merged into main in commit 7ed8b939e, adding the five actionable Candid credential errors (unset SNAPCRAFT_STORE_AUTH, run 'export-login', or 'logout'/'login') and resolving issue #6414. It was approved by 2 reviewers with no unresolved comments; the only red checks were store/openstack spread tests and a lint job that failed on a 403 fetching an external KDE URL.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The candid auth mechanism is being shut down, so Snapcraft removed support for it in #6288. However, the error messages weren't user-friendly, so this PR adds better errors and advice on how to fix them. As a quick refresher: to use candid, you need to set `SNAPCRAFT_STORE_AUTH=candid` and use candid credentials. Crendentials can come from a keyring (`snapcraft login`) or an envvar (`snapcraft export-login`). In short, this code in this PR may seem overcomplicated but because of the permuatations listed above, we need to present users with one of the following errors: * `Unset SNAPCRAFT_STORE_AUTH to login with Ubuntu One.` * `Unset SNAPCRAFT_STORE_AUTH and run 'snapcraft export-login' to generate new credentials.` * `Unset SNAPCRAFT_STORE_AUTH and run 'snapcraft logout' and 'snapcraft login' to generate new credentials.` * `Run 'snapcraft export-login' to generate new credentials.` * `Run 'snapcraft logout' and 'snapcraft login' to generate new credentials.` Fixes #6414 (SNAPCRAFT-1381) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as 7ed8b939e: adds user-friendly errors and recovery advice for obsolete Candid store credentials, closing #6414 (SNAPCRAFT-1381). Lint failure was an unrelated 403 fetching an external KDE link.
stealth/space-bunny-alpha — closed resolved PR #6417 was merged in commit 7ed8b939e, adding actionable errors for obsolete Candid credentials and resolving #6414. It covered Ubuntu One and credential-export/login recovery paths.
qwen/qwen3.6-35b-a3b — — Merged improved error messages for deprecated candid credentials. The PR replaces cryptic errors with actionable migration guidance for Ubuntu One auth, resolving #6414 after reviewer approval.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 34
Staleness: 5
Complexity: 25
Confidence: 85
needs review Adds user-friendly error messages when candid credentials are detected after candid auth was removed in #6288. Has 2 approvals, 0 unresolved comments, mostly passing CI.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 40
Staleness: 0
Complexity: 20
Confidence: 80
needs review Adds user-friendly migration errors for candid credentials after Snapcraft removed candid auth support in #6288. Approved by 1 reviewer, CI passing.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 34
Staleness: 5
Complexity: 25
Confidence: 75
needs review Adds user-friendly error messages when candid authentication is used, guiding users to switch to Ubuntu One or regenerate credentials. Fixes #6414.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 29
Staleness: 0
Complexity: 35
Confidence: 70
needs review Adds user-friendly error messages when candid credentials are detected after Snapcraft removed candid auth support. Fixes #6414. New PR from maintainer, pending review, one failing lint check.

Update history

Date Change
closed
updated
updated
updated
updated
created

Related work

  • Related To: canonical/snapcraft#6414 (confidence 95%)

    The issue this PR declares as fixed ('Fixes #6414'); that issue was previously closed with no implementation, so this PR supplies the missing behavior.

  • Related To: canonical/snapcraft#6288 (confidence 70%)

    Prior removal of Candid auth support that left the unfriendly error messages this PR improves; cited in the PR body.

Related issues

Issue Project State Summary Similarity
#5536 fix(store): catch credential decoding errors snapcraft merged Merged in canonical/snapcraft#5536 (commit 3784560f3), converting malformed store credential decoding failures into a user-friendly error and updating craft-store.
77%
#6098 fix: Tweak error message about SNAPCRAFT_STORE_CREDENTIALS snapcraft merged Merged in commit ee69b79b1, clarifying that login cannot be used while SNAPCRAFT_STORE_CREDENTIALS is set and removing ambiguous wording.
71%