← Back to issue list

chore: remove snapcraft_legacy

View original Github issue

Metadata

Project
snapcraft
Number
#6241
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged removal of the snapcraft_legacy module, old specs folder, and dependencies after verifying no remaining entry points. Approved by two reviewers; noted unrelated integration test failures.

Suggested action:

No scores available.

Issue body

Removes snapcraft_legacy, now that the code has no entry points. Also removes the old specs folder and drops snapcraft_legacy dependencies. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged removal of the snapcraft_legacy module, old specs folder, and dependencies after verifying no remaining entry points. Approved by two reviewers; noted unrelated integration test failures.
qwen3.6-35b-a3b-mtp-q6 Merged by maintainer mr-cal after removing snapcraft_legacy code, the old specs folder, and associated dependencies following the elimination of entry points. CI spread failures were deemed unrelated.
qwen3.6-35b-a3b-mtp-q6 Merged removal of snapcraft_legacy, its specs folder, and dependencies after all entry points were eliminated. Maintainer confirmed unrelated CI spread failures did not block the merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1357 chore: remove unused docs requirements file craft-parts merged Merged removal of an unused docs requirements file to eliminate Renovate PR noise. Approved by two reviewers with all CI checks passing, following a prior cleanup in the Snapcraft project.
78%
#1078 chore!: remove deprecated APIs craft-application merged Merged, removing 8 deprecated APIs from craft-applications to resolve issue #1063. Approved by two reviewers with all CI checks passing. Locally verified with snapcraft, reducing code by 345 lines across 11 files.
77%
#5821 chore(legacy): remove script entry point snapcraft merged Merged removal of a legacy script entry point causing user confusion. Approved by two reviewers, passed CI checks, and deleted a single line in one file to clean up the codebase.
76%
#5528 chore: address all snapcraft.io/docs links snapcraft merged Merged following two approvals. Standardized snapcraft.io/docs links across 91 files. A failing integration test on Ubuntu 20.04 did not block the merge. A force-push exception was granted to combine documentation and code changes.
75%
#76 chore: add snapcraft project files debcraft merged Merged changes adding snapcraft project files to decouple support libraries from lxd and snap infrastructure for Debcraft. Approved by two reviewers with all CI checks passing. Diff includes 120 additions across two files.
75%
#4852 chore(merge): '8.2.11' into 'main' snapcraft merged Merged version 8.2.11 into main. Resolved a minor conflict in snapcraft.application.Application._get_dispatcher(). Approved by two reviewers with passing CI checks. Changes include 173 additions and 28 deletions across 9 files.
74%
#1254 chore(deps): update internal packages charmcraft merged Merged automated dependency updates for craft-cli, craft-parts, and snap-helpers. Approved by two reviewers and passed CI checks before integration.
73%
#984 chore(deps): update internal packages charmcraft merged Merged automated dependency updates for craft-parts, craft-providers, and snap-helpers. Approved by a reviewer and passed CI checks before integration.
73%
#6288 chore(store)!: remove candid login snapcraft merged Merged after two reviewer approvals and passing CI checks. The change removes the candid login method from Snapcraft (SNAPCRAFT-1254), updating seven files with a net reduction of 27 lines.
72%
#5540 chore: resolve deprecation warnings snapcraft merged Merged to resolve deprecation warnings before they become errors. Updates test mocking context manager setup. Approved by two reviewers and merged despite one failing integration test. Closes #5539.
72%