← Back to issue list

feat: error when --pro is used for core22

View original Github issue

Metadata

Project
snapcraft
Number
#6317
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #6317 merged: adds validation rejecting `--pro` for core22 snaps (CRAFT-5226), +83 lines across 4 files. Author confirmed remaining CI failures (spread tests, lint/files, OSV-scanner) were unrelated.

Resolution: closed resolved

Reason: The pull request itself was merged into snapcraft after approval by 2 reviewers, implementing the CRAFT-5226 check that errors when --pro is used with base core22. The maintainer commented that the failing CI jobs were unrelated to the change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Errors when using `--pro` for core22 snaps. (CRAFT-5226) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #6317 merged: adds validation rejecting `--pro` for core22 snaps (CRAFT-5226), +83 lines across 4 files. Author confirmed remaining CI failures (spread tests, lint/files, OSV-scanner) were unrelated.
stealth/space-bunny-alpha — closed resolved Merged validation that rejects --pro for core22 snaps, addressing CRAFT-5226. The maintainer confirmed that remaining CI failures were unrelated.
qwen/qwen3.6-35b-a3b — — Merged to add validation that errors when the --pro flag is used with core22 base snaps. Resolves CRAFT-5226. Approved by two reviewers despite unrelated CI failures.
qwen3.6-35b-a3b-mtp-q6
Staleness: 0
Complexity: 15
Confidence: 90
needs review Adds a validation check to return an error when the --pro flag is used with core22 bases. Freshly opened by a maintainer, awaiting initial review and CI validation.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4693 (confidence 40%)

    Earlier merged work established core24/Craft Application and core22 component handling, the behaviour that --pro validation now constrains.

Related issues

Issue Project State Summary Similarity
#6450 fix(test): error for core22 snaps snapcraft closed PR #6450 proposed an early core22 error for snapcraft test, but was closed unmerged with review pending; #5479 remains open.
71%