fix(test): error for core22 snaps
Metadata
Current evaluation
PR #6450 proposed an early core22 error for snapcraft test, but was closed unmerged with review pending; #5479 remains open.
Resolution: closed stale
Reason: No merge commit was found, and the PR remained pending review with no closing explanation. Its target issue #5479 remains open, so the proposed fix was abandoned.
Evaluated by: mr-cal-bot
No scores available.
Issue body
`snapcraft test` isn't part of the core22 command group, so for core22 projects it ran craft-application's test workflow, which doesn't support core22 and builds in an Ubuntu 24.04 environment.
Following the approach suggested in the issue, `snapcraft test` now uses a small subclass of craft-application's `TestCommand` that fails early for core22 projects, the same way `snapcraft try` does for the bases it doesn't support:
```
Command or feature not implemented: 'snapcraft test' is not implemented for 'core22'
```
core24 and newer projects aren't affected.
Fixes #5479
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #6450 proposed an early core22 error for snapcraft test, but was closed unmerged with review pending; #5479 remains open. | |
| qwen/qwen3.8-27b | — | closed stale | PR to make snapcraft test fail early for core22 projects with FeatureNotImplemented error, fixing #5479. Closed while still pending review with no merge commit found; issue #5479 remains open. | |
| stealth/space-bunny-alpha |
Impact:
42
Quick Win:
24
Complexity:
24
Confidence:
92
Actionability:
76
|
needs review | Overrides snapcraft test to reject core22 projects instead of using the unsupported Ubuntu 24.04 workflow; core24+ stays unchanged. Ready for maintainer review with no unresolved feedback. |
Update history
| Date | Change |
|---|---|
| closed | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
canonical/snapcraft#5479
(confidence 100%)
The PR stated that it fixed #5479; that issue remains open because the PR was closed unmerged.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5479 `test` command always builds with Ubuntu 24.04 | snapcraft | open | `snapcraft test` on a core22 snap silently builds with Ubuntu 24.04 instead of erroring. Triaged by maintainers; PR #6450 (fail early for core22) was closed unmerged, so the bug is still present in the tree. | |
| #5634 Core22 unit tests in snapcraft fails with craft application 5.5.0 | snapcraft | closed | Closed as deferred with no direct fix; craft-application#812 remained identified as the source of the core22 validation regression in 5.5.0. | |
| #6336 Snapcraft 9: snapcraftctl errors in core22 snaps | snapcraft | closed | Fixed a validator bug preventing core22/core24 snaps without a `base` key from using `snapcraftctl`. Merged as #6499, resolving #6336. | |
| #3731 tests: fix content provider snap not found for core22 | snapcraft | merged | PR #3731 merged via commit 7fbaf82d (topic 83e8991, merge 5edd183c) into snapcraft 7.0; adjusted spread-test expected error text so core22's differing 'content provider snap not found' message passes. | |
| #5774 Remove all snapcraftctl code and compatibility wrapper for core22 | snapcraft | closed | PR to strip snapcraftctl code for core22 was closed unmerged: maintainers (mr-cal) said removal can't happen for core22/core24 as it would break existing builds, so the wrapper was kept. Later #5983 (eaadefa01) errors on snapcraftctl only in core26. | |
| #5754 Remove the `snapcraftctl` compatibility wrapper | snapcraft | closed | Closed as won't-fix by mr-cal: snapcraftctl wrapper must stay for core22/core24 to avoid breaking existing builds. Implementation PR #5774 was closed unmerged; #5983 (eaadefa01) only makes core26 error on snapcraftctl. | |
| #4186 snap: migrate to core22 | snapcraft | merged | PR #4186 merged, moving the Snapcraft snap's own build environment to base core22 (8 files, +71/-70), landing as commit 60033305b and closing the core22 migration issue #4166. | |
| #1866300 snapcraft fails to build core20 snap | snapcraft (launchpad) | closed | Closed without a documented fix after core20 Multipass/LXD failures; core20 build-base support was unavailable and the workaround was destructive mode. | |
| #56 feat(snapcraft): snapcraft test action | craft-actions | closed | PR #56 was closed unmerged after prolonged inactivity; snapcraft/test was never added, and #54 remains open. | |
| #1981072 Core22 Snap builds don't output error logs | snapcraft (launchpad) | closed | Launchpad core22 snap builds showed no error output. Closed as fixed after snapcraft PR canonical/snapcraft#3889 (commit 72ad273f2) plus craft-parts logging fixes; maintainer confirmed Snapcraft 8 reports stdout/stderr for core22 builds. |