If "source: .." do not copy the current directory into itself.
Metadata
Current evaluation
Superseded by canonical/snapcraft#725, merged as a3d662744; it fixed LP #1600428 by excluding the snapcraft.yaml directory from parent-source traversal.
Resolution: closed superseded
Reason: A maintainer closed #645 in favor of canonical/snapcraft#725 due to inactivity. The replacement PR merged as commit a3d662744 and implemented the intended source-directory exclusion.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This fixes [LP: #1600428](https://bugs.launchpad.net/snapcraft/+bug/1600428) by skipping over the directory containing the snapcraft.yaml when `source: ..`
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Superseded by canonical/snapcraft#725, merged as a3d662744; it fixed LP #1600428 by excluding the snapcraft.yaml directory from parent-source traversal. | |
| stealth/space-bunny-alpha | — | closed superseded | PR #645 was superseded by merged PR #725 (commit a3d662744), which fixed LP: #1600428 by skipping the snapcraft.yaml directory when copying a local parent source. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed in favor of PR #725 due to inactivity. The contribution aimed to prevent copying the current directory into itself when using source: .., but reviewers requested an integration test that was never provided. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed in favor of PR #725 due to inactivity. The change attempted to prevent copying the current directory into itself when source: .. was used, but stalled while awaiting an integration test. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#725
(confidence 100%)
Merged replacement fixing the same LP #1600428 recursion problem.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1600428 Setting source: .. causes pull to fail | snapcraft (launchpad) | closed | Fixed by snapcore/snapcraft#725, adding support for snapcraft.yaml in a subdirectory and preventing recursive source copying. | |
| #2256 local source: don't include .snapcraft directory | snapcraft | merged | Merged #2256 (commit abbc92427), fixing LP #1791773 by excluding .snapcraft from local-source copies and stale-part checks. | |
| #1644350 Runnig snapcraft with sources on parent folders (over one level) causes infinite loops | snapcraft (launchpad) | closed | Fixed by merged snapcore/snapcraft PR #926: local source traversal now excludes generated Snapcraft directories, preventing recursive copies when building from project subdirectories. | |
| #1827216 local source must not specify parent directories | snapcraft (launchpad) | open | Reported local-source confinement is obsolete: current craft-parts accepts relative parent paths, and Snapcraft spread tests cover sources ../.. and ../../.. | |
| #1549676 source-subdir says its "a source dir within a repo to build from" but misses that snapcraft will only copy that subdir | snapcraft (launchpad) | closed | Fixed by merged ubuntu-core/snapcraft#344 (commit 6beb6fec6): Snapcraft now copies the full repository while building from the selected source-subdir. | |
| #1575628 Snapcraft doesn't ignore already-built snaps when `source` is the folder containing the `snapcraft.yaml` | snapcraft (launchpad) | closed | Snapcraft now filters *.snap files from sourcedir, preventing rebuilt artifacts from being copied into part build directories; shipped in version 2.10.1. |