← Back to issue list

Allow godeps to fetch Go dependencies

View original Github issue

Metadata

Project
snapcraft
Number
#675
Type
pull request
State
closed
Author
stevenwilkin
Labels
—
Created
Updated
Closed

Current evaluation

Unmerged; kyrofa closed it in favour of #691, which added a proper godeps plugin and was merged as commit a073503c0, fixing LP bug #1595981.

Resolution: closed superseded

Reason: Maintainer kyrofa closed the PR on 2016-07-27 with the comment "Closing in favor of #691." PR #691 added a dedicated Godeps plugin and was merged as commit a073503c0, resolving LP bug #1595981.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Addresses LP: [#1595981](https://bugs.launchpad.net/snapcraft/+bug/1595981) This PR crudely allows [godeps](https://launchpad.net/godeps) to manage dependencies for Go projects, for example [snapweb](https://github.com/snapcore/snapweb). One thing to note is that `go get` still gets run after `godeps` which is maybe redundant but this effort is the simplest way of closing the bug.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Unmerged; kyrofa closed it in favour of #691, which added a proper godeps plugin and was merged as commit a073503c0, fixing LP bug #1595981.
stealth/space-bunny-alpha — closed superseded Closed in favor of #691, which added a Godeps plugin and was merged as commit a073503c0.
qwen/qwen3.6-35b-a3b — — Superseded by #691. Maintainer @kyrofa closed the request and directed the author to test the alternative PR, which offers a more complete solution for managing Go dependencies with godeps.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by pull request #691. The godeps integration was closed in favor of a replacement implementation. Contributors were directed to test the alternative pull request instead.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#691 (confidence 98%)

    Explicitly cited in the closing comment; merged as commit a073503c0 adding snapcraft/plugins/godeps.py.

  • Related To: snapcraft#1179 (confidence 60%)

    Follow-up merged PR (commit 10c46b8ad) adding git to the godeps plugin's build-packages, refining the merged #691 work.

Related issues

Issue Project State Summary Similarity
#691 Add godeps plugin. snapcraft merged Godeps plugin merged into snapcraft via commit a073503c0 (PR #691), adding Go godeps dependency support and resolving LP bug #1595981; later enhanced by follow-up PRs.
77%
#1057 godeps plugin: support for go-packages. snapcraft merged Merged PR #1057 as commit 81f56fd13, adding go-packages support to the Godeps plugin so builds can target specified Go packages.
71%