← Back to issue list

godeps plugin: add git to build-packages

View original Github issue

Metadata

Project
snapcraft
Number
#1179
Type
pull request
State
merged
Author
cjwatson
Labels
Created
Updated
Closed

Current evaluation

Merged a patch adding git to the godeps plugin build-packages. The change resolves a missing dependency for go get commands. Approved by one reviewer and merged directly without CI checks.

Suggested action:

No scores available.

Issue body

The godeps plugin runs "go get github.com/rogpeppe/godeps", which requires git to be installed. LP: #1671546

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a patch adding git to the godeps plugin build-packages. The change resolves a missing dependency for go get commands. Approved by one reviewer and merged directly without CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged. Added git to the godeps plugin build-packages to resolve missing dependency for go get. Approved by sergiusens.
qwen3.6-35b-a3b-mtp-q6 Merged changes adding git to the godeps plugin build-packages. This resolves a missing dependency that caused plugin failures, fixing LP: #1671546.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1057 godeps plugin: support for go-packages. snapcraft merged Merged into master, adding go-packages support to the godeps plugin to match the go plugin. Approved by a reviewer, passed CI checks, and increased overall code coverage.
84%
#1671546 godeps plugin does not installing the git package by itself snapcraft (launchpad) closed Closed without a fix. The godeps plugin fails to install git automatically, causing go get to fail. Users must manually add git to build-packages as a workaround.
80%
#2328 godeps plugin: support for bases snapcraft merged Merged. Updated the godeps plugin to prioritize the Go snap and added support for installing golang-go via build-packages on supported bases. Approved, passed CI, and integrated.
79%
#1046 godeps plugin: work when GOBIN is set snapcraft merged Merged into master. Resolves LP: #1656118 by fixing the godeps plugin to function correctly when GOBIN is set. Approved by one reviewer, passed CI, and modified two files (+15/-1 lines).
78%
#1000 Updated godeps plugin to use get_pull_properties() snapcraft merged Merged changes updating the godeps plugin to use get_pull_properties() and adding corresponding unit tests. Approved by one reviewer with 96.33% code coverage across two files.
72%
#3285 v1 plugins: lock godep's dependencies snapcraft merged Merged changes locking godeps dependencies, specifically go-toml, to prevent breakage on older Go versions. The update checks out correct revisions after downloading via go-get. Approved by one reviewer and passed all CI checks.
72%
#691 Add godeps plugin. snapcraft merged Merged the godeps plugin for Snapcraft, resolving Launchpad bug #1595981. The change simplifies snapcraft.yaml for Go projects like Juju and adds tag support. Approved and verified by multiple contributors prior to integration.
71%
#2200 tests: add spread suite for godeps plugin snapcraft merged Merged changes move Godeps plugin integration tests to a Spread suite, resolving Launchpad bug #1783833. Approved by one reviewer, passed CI, and updated 12 files. Codecov noted a minor 0.08% coverage decrease.
70%