godeps plugin: add git to build-packages
Metadata
Current evaluation
Merged in canonical/snapcraft#1179 via commit 10c46b8ad, adding git to the godeps plugin’s build-packages so its go get invocation can complete.
Resolution: closed resolved
Reason: The approved PR was merged and implemented the fix in commit 10c46b8ad.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The godeps plugin runs "go get github.com/rogpeppe/godeps", which
requires git to be installed.
LP: #1671546
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#1179 via commit 10c46b8ad, adding git to the godeps plugin’s build-packages so its go get invocation can complete. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1179 (commit 10c46b8ad), adding git to the godeps plugin's build-packages so its go get invocation can complete without manual setup. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a patch adding git to the godeps plugin build-packages. The change resolves a missing dependency for go get commands. Approved by one reviewer and merged directly without CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added git to the godeps plugin build-packages to resolve missing dependency for go get. Approved by sergiusens. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1671546 godeps plugin does not installing the git package by itself | snapcraft (launchpad) | closed | Fixed in snapcore/snapcraft#1179, merged as commit 10c46b8ad; the godeps plugin now adds git to build-packages. | |
| #691 Add godeps plugin. | snapcraft | merged | Godeps plugin merged into snapcraft via commit a073503c0 (PR #691), adding Go godeps dependency support and resolving LP bug #1595981; later enhanced by follow-up PRs. | |
| #1657212 Godeps plugin support to build only needed binaries | snapcraft (launchpad) | closed | Godeps gained go-packages support to build selected binaries via snapcore/snapcraft PR #1057, merged as commit 81f56fd13. | |
| #1595981 Need a godeps plugin | snapcraft (launchpad) | closed | Godeps plugin support was merged in snapcore/snapcraft#691 via commit a073503c0. | |
| #2328 godeps plugin: support for bases | snapcraft | merged | Merged PR #2328 as commit e1393815d, adding base-aware godeps support that prefers the Go snap and can install golang-go as a build package. | |
| #1057 godeps plugin: support for go-packages. | snapcraft | merged | Merged PR #1057 as commit 81f56fd13, adding go-packages support to the Godeps plugin so builds can target specified Go packages. | |
| #1794784 Update the godeps plugin to be base aware | snapcraft (launchpad) | closed | Godeps gained base support through snapcore/snapcraft PR #2328, implemented by commit e1393815d. | |
| #1922150 godeps using seemingly invalid commit hash | snapcraft (launchpad) | closed | Fixed by merged snapcore/snapcraft#3475 (commit a6dfe1cd2), which defaulted the unmaintained godeps plugin to Go 1.15/stable; the reporter confirmed the workaround restored CI. | |
| #1137 Build-depend on git | snapcraft | merged | Merged in canonical/snapcraft#1137 (commit 8b3cb387d), adding git as a direct build dependency so Git source tests can invoke git. | |
| #1650624 Update godeps plugin to use get_pull_properties | snapcraft (launchpad) | closed | Godeps was refactored to use get_pull_properties() with updated tests; merged via snapcore/snapcraft#1000 at commit 9b8303005. |