← Back to issue list

Improve the go plugins usability

View original Github issue

Metadata

Project
snapcraft
Number
#709
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged to improve Go plugin usability by combining source keywords with go-packages, enabling selective main package builds and remote fallback. Reviewer feedback on tests and build tags was incorporated before approval. The update modifies seven files.

Suggested action:

No scores available.

Issue body

Allow full use of source keywords combined with go-packages which has the side effect of building the select main packages from those sources and falls back to fetching the dependencies remotely through go get's default behavior. LP: #1599328 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to improve Go plugin usability by combining source keywords with go-packages, enabling selective main package builds and remote fallback. Reviewer feedback on tests and build tags was incorporated before approval. The update modifies seven files.
qwen3.6-35b-a3b-mtp-q6 Merged after addressing reviewer feedback. Enhances Go plugin usability by enabling source keywords with go-packages, building main packages locally, and falling back to remote dependency fetching. Includes integration tests for multiple main packages.
qwen3.6-35b-a3b-mtp-q6 Merged to improve Go plugin usability. Enables source keyword usage with go-packages, builds main packages locally, and falls back to remote fetching. Added integration tests for multiple main packages and approved after enabling LXD builds.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#997 plugins: update go plugin to use get_build_properties() snapcraft merged Merged after approval and passing CI. Updates the Go plugin to use get_build_properties(), adjusts the schema test, and adds unit tests for get_pull_properties() and get_build_properties(). Changes successfully integrated.
73%
#1343 go plugin: Cross compile with CGo snapcraft merged Merged to enable cross-compilation for Go plugins when CGo is enabled. Approved by one reviewer, the change updates seven files with 83 additions and 7 deletions to correctly handle CGo flags during cross builds.
72%
#271 plugins: support "go generate" in go parts craft-parts merged Merged. Integrates go generate into the GoPlugin build step to execute code generation prior to compilation. Approved by a reviewer, passed CI checks, and modified five files. The change is backward compatible and resolves CRAFT-1316.
71%
#733 Add the go-buildtags property to the go plugin snapcraft merged Merged by maintainer come-maiz, adding the go-buildtags property to the go plugin. The update modifies two files with 166 additions and 5 deletions, implementing the feature requested in LP #1609623.
71%
#78 plugins: add go plugin (CRAFT-48) craft-parts merged Merged a Go plugin for go.mod-based projects, adapted from Snapcraft V2. Approved by two reviewers, passed CI, and introduced 425 additions across seven files. Co-authored by Sergio Schvezov.
71%