Improve the go plugins usability
Metadata
Current evaluation
Merged as 57359d5d0: Go plugins now combine source keywords with go-packages, build selected main packages, and fetch missing dependencies via go get.
Resolution: closed resolved
Reason: PR #709 was merged in commit 57359d5d0, implementing improved source handling and building behavior for the Go plugin.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Allow full use of source keywords combined with go-packages
which has the side effect of building the select main packages
from those sources and falls back to fetching the dependencies
remotely through go get's default behavior.
LP: #1599328
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as 57359d5d0: Go plugins now combine source keywords with go-packages, build selected main packages, and fetch missing dependencies via go get. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #709 as 57359d5d0, allowing Go plugins to combine source keywords with go-packages, build selected main packages, and fetch missing dependencies remotely. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#709 (57359d5d0), improving Go plugin usability by combining sources with go-packages, building selected main packages, and fetching missing dependencies remotely. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #709 merged as commit 57359d5d0: Go plugins now combine source keywords with go-packages, build the selected main packages, and fall back to fetching deps remotely via go get. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 57359d5d0: Snapcraft's Go plugin gained support for source keywords combined with go-packages, building selected main packages and falling back to go get for remote deps (LP #1599328). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#709 (57359d5d0): Go plugins now combine source keywords with go-packages, build selected main packages, and fall back to remote dependency fetching. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to improve Go plugin usability by combining source keywords with go-packages, enabling selective main package builds and remote fallback. Reviewer feedback on tests and build tags was incorporated before approval. The update modifies seven files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after addressing reviewer feedback. Enhances Go plugin usability by enabling source keywords with go-packages, building main packages locally, and falling back to remote dependency fetching. Includes integration tests for multiple main packages. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#733
(confidence 95%)
Follow-up PR adding go-buildtags support requested during review of #709.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1355 go plugin: filter the main packages go-packages are defined | snapcraft | merged | Merged PR #1355 as commit 3b4dc5628, updating the Go plugin to build only main packages when go-packages is unset because go build -o cannot use ./... across all packages. | |
| #1057 godeps plugin: support for go-packages. | snapcraft | merged | Merged PR #1057 as commit 81f56fd13, adding go-packages support to the Godeps plugin so builds can target specified Go packages. |