← Back to issue list

Fix `git clone` when transport is http and it does not support --depth

View original Github issue

Metadata

Project
snapcraft
Number
#792
Type
pull request
State
closed
Author
ehbello
Labels
—
Created
Updated
Closed

Current evaluation

PR #792 (drop --depth=1 for HTTP git sources) was closed unmerged; maintainers landed the fix differently in merged PR #814 (commit 190463c3c), making shallow clones opt-in via the source-depth part property, tracking LP bug #1617783.

Resolution: closed superseded

Reason: PR #792 was closed without merging. In snapcraft#814 (commit 190463c3c, "Make source-depth a parameter and opt-in"), the maintainers removed --depth=1 by default and made it an explicit opt-in property, as stated by sergiusens in the closing comment referencing Launchpad bug #1617783.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This pull request remove `--depth=1` of HTTP transport for Git due there are repositories as git.kernel.org that does not support that. Signed-off-by: Enrique Hernández Bello ehbello@gmail.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #792 (drop --depth=1 for HTTP git sources) was closed unmerged; maintainers landed the fix differently in merged PR #814 (commit 190463c3c), making shallow clones opt-in via the source-depth part property, tracking LP bug #1617783.
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded by #814, which removed --depth=1 from the default HTTP clone and made shallow cloning opt-in via source-depth.
qwen/qwen3.6-35b-a3b — — Superseded by PR #814, which removes --depth=1 entirely and makes it opt-in. The original proposal was closed without merging after maintainers implemented a broader change.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #814, which makes shallow cloning opt-in instead of conditionally removing --depth=1 for HTTP transports. The original PR was closed without merging.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#814 (confidence 95%)

    Merged PR that removed --depth=1 by default and made it opt-in via source-depth; referenced directly by the closing maintainer comment.

  • Related To: snapcraft#829 (confidence 55%)

    Follow-up PR (commit b492a5a41) fixing the type when calling sources with depth, related to the same source-depth feature.

Related issues

Issue Project State Summary Similarity
#1617783 Git clone with --depth=1 loses the tags snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#814 (commit 190463c3c): Git clones became full-depth by default, with source-depth available as an explicit opt-in.
74%
#248 Git source: Make a shallow clone. snapcraft merged Merged #248 (commit 6ebd8e68d; merge 321b13277), changing Git sources from full clones to depth-1 shallow clones and resolving LP #1536696.
72%