plainbox-provider plugin: rewrite python shebangs
Metadata
Current evaluation
Merged as a7771b8e4: added shebang rewriting to the plainbox-provider plugin so installed Python scripts use the in-snap interpreter, fixing LP #1626587. Approved despite 4 unresolved review comments.
Resolution: closed resolved
Reason: PR #823 was merged into the project as commit a7771b8e4 ('plainbox-provider plugin: rewrite python shebangs'), adding replace_in_file calls in the plugin's build() to rewrite '#!.*python' shebangs to '#!/usr/bin/env python'. This closed LP bug #1626587; Leo Arias' request for unit tests was noted but not required, as the comment states there are no unit tests for this plugin.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as a7771b8e4: added shebang rewriting to the plainbox-provider plugin so installed Python scripts use the in-snap interpreter, fixing LP #1626587. Approved despite 4 unresolved review comments. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #823 (a7771b8e4): rewrote Python shebangs in the plainbox-provider plugin to use /usr/bin/env python, addressing LP #1626587. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged rewrite of Python shebangs in the plainbox-provider plugin to use /usr/bin/env python. Approved by two reviewers across five files. Resolves LP: #1626587. Missing unit tests were noted but acknowledged as unavailable. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a rewrite of Python shebangs in the plainbox-provider plugin to use the in-snap Python. A reviewer requested unit tests, but the author noted the plugin lacks existing test coverage. The change was merged without additional tests. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1626587
(confidence 98%)
Launchpad bug referenced as 'LP: #1626587' in the PR body; closed by this merge.
-
Likely Fixed By:
snapcraft#830
(confidence 90%)
Follow-up PR merged as 60e29ef1b restricting the python plugin's shebang replacement to proper file-beginning shebangs, resolving conflicts introduced by this change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1626587 plainbox-provider plugin python shebangs are mismatched | snapcraft (launchpad) | closed | Fixed by merged PR #823 (a7771b8e4), adding plainbox-provider shebang rewriting; PR #830 (60e29ef1b) then narrowed Python-plugin rewriting and removed remaining conflicts. | |
| #830 python plugin: only replace proper shebangs. | snapcraft | merged | Merged as commit 60e29ef1b, restricting Python plugin shebang replacement to file beginnings and fixing LP #1626587-related plainbox conflicts. |