Fixing 'sign-build' integration tests.
Metadata
Current evaluation
Merged in canonical/snapcraft#839 as commit b67a60d58, fixing sign-build integration tests by registering snap names and exposing them through the fake account-info endpoint.
Resolution: closed resolved
Reason: PR canonical/snapcraft#839 was merged as commit b67a60d58. It registers the random snap name before signing and updates the fake store to return registered names via account-info.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Even for building the local assertion, the command actually checks if the
account logged in has upload permission on the targeted snap (resolving
name to snap-id via account-info).
The test now builds an random snap, register the name in the store and
only then signs the snap. The fake server was extended to record registered
names and return them in the account-info endpoint.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#839 as commit b67a60d58, fixing sign-build integration tests by registering snap names and exposing them through the fake account-info endpoint. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #839 merged as commit b67a60d58, fixing sign-build tests by registering the random snap name and exposing it through the fake server's account-info response. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #839 fixed sign-build integration tests by registering random snap names before signing and exposing them through the fake account-info endpoint (commit b67a60d58). | |
| stealth/space-bunny-alpha | — | closed resolved | PR #839 was merged, fixing sign-build integration tests by registering the random snap name before signing and exposing it through the fake account-info endpoint. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #839 fixed sign-build integration tests by registering the random snap name before signing and returning registered names through the fake server's account-info endpoint. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for sign-build integration tests. Updated the test to build, register, and sign a snap, and extended the fake server for account-info. Approved by one reviewer; merged with 57 additions and 17 deletions across three files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for 'sign-build' integration tests. Updated the test to register the snap name before signing and extended the fake server to return registered names via the account-info endpoint, resolving permission check failures. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1247 Fixing Store integration tests. | snapcraft | merged | Merged in canonical/snapcraft#1247 as 03105a6c4, updating Store integration tests and registration error handling for the new 40-character snap-name limit. | |
| #831 'sign-build' implementation. | snapcraft | merged | Merged as commit ded7281c9, adding sign-build to generate, sign, and optionally push snap-build assertions; superseded PR #795. | |
| #5826 fix: parse a snap file for the sign-build command | snapcraft | merged | Merged PR #5826 (commit bf00a385e) fixed sign-build snap-file parsing and removed duplicate --local help text; it fixes #5618. | |
| #1964 Fix Store integration tests with updated snap name registration error messages (take 2) | snapcraft | merged | Merged in canonical/snapcraft#1964 as commit 44ecb321a, updating Store integration tests for new snap-name registration errors; it supersedes #1963. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged #4755, fixing the devel-base integration test to verify Snapcraft can create the base snap and that the resulting devel base is usable. |