catkin plugin: detect and gracefully handle rosinstall clashes
Metadata
Current evaluation
Abandoned as unnecessary: recursive rosinstall fetching was supported via #1934 (6bb63bb25), and @kyrofa said clash detection offered no gain.
Resolution: closed stale
Reason: @kyrofa recommended cancellation in the 2018-03-05 closing discussion, noting that recursive fetching was supported and vendors saw no need for clash detection. PR #1934 added recursive rosinstall support for #1714 but did not implement the proposed clash handling.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Estimate: 5 days
The Catkin plugin currently supports parsing rosinstall files to pull the various repositories that make up the workspace that it will build. A request from Shadow Robotics is to add the ability to then look inside the pulled workspace for more rosinstall files, and fetch their repositories as well. This is not supported by rosinstall alone. Would be nice if Snapcraft was smart enough to know if rosinstall files clash with each other (e.g. file A requires repo foo, hash 1234, file B requires repo foo hash abcd).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | Abandoned as unnecessary: recursive rosinstall fetching was supported via #1934 (6bb63bb25), and @kyrofa said clash detection offered no gain. | |
| stealth/space-bunny-alpha | — | closed stale | Closed by maintainer @kyrofa (2018-03-05) as not worth doing: recursive rosinstall fetching is already supported and clash detection offers "a lot of pain for really no gain". The related recursive-fetch request shipped in PR #1934 (6bb63bb25). | |
| stealth/space-bunny-alpha | — | closed stale | Abandoned after maintainer review: @kyrofa said recursive fetching was supported, but rosinstall clash detection offered little gain and recommended cancellation unless explicitly requested. | |
| qwen/qwen3.6-35b-a3b | — | — | Rejected. Maintainer cancelled the feature because vendors do not require recursive rosinstall parsing or clash detection, and recursive fetching is already supported. Low demand and implementation complexity led to abandonment. | |
| qwen/qwen3.6-35b-a3b | — | — | Rejected due to low vendor demand and high implementation cost. Maintainer noted recursive rosinstall fetching is already supported, making clash detection unnecessary. Issue closed as abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | The request to detect rosinstall file clashes in the catkin plugin was rejected. A maintainer determined the feature would add unnecessary complexity with little practical benefit, as vendors do not require it, and recommended cancelling the extension. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Rejected due to low vendor demand and high implementation cost. Recursive rosinstall parsing and clash detection for the catkin plugin will not be implemented unless explicitly requested. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#1714
(confidence 98%)
Companion issue for recursively merging nested rosinstall files.
-
Related To:
canonical/snapcraft#1934
(confidence 98%)
Merged commit 6bb63bb25 added opt-in recursive rosinstall support.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1714 catkin plugin: recursively merge rosinstall files | snapcraft | closed | Added opt-in recursive rosinstall support to the Catkin plugin, discovering and merging nested rosinstall files in canonical/snapcraft#1934. | |
| #1533735 Catkin plugin: Support rosinstall files | snapcraft (launchpad) | closed | Catkin rosinstall support was merged in PR #1314 (commit 97a416d0a); rosinstall-files was later corrected to a pull property in #1473. | |
| #1934 catkin plugin: support recursive rosinstall files | snapcraft | merged | Merged PR #1934 (commit 6bb63bb25) adds an opt-in `recursive-rosinstall` option to the Catkin plugin, merging nested rosinstall files from fetched repos. Fixes issue #1714; tested on the stable/pr-1934-recursive-rosinstall channel. | |
| #1314 catkin plugin: add support for rosinstall files | snapcraft | merged | Merged PR #1314 as commit 97a416d0a, adding ordered multi-file rosinstall support to the Catkin plugin and resolving Launchpad #1533735. | |
| #1473 catkin plugin: rosinstall-files is a pull property | snapcraft | merged | Merged PR #1473 corrected the catkin plugin to treat rosinstall-files as a pull property, committed as 09fcddf13. | |
| #851 catkin plugin: nicely handle an invalid rosdistro. | snapcraft | merged | Merged PR #851 as d37b7cda8: the catkin plugin now validates rosdistro and reports a helpful error instead of raising an unfriendly KeyError. |