← Back to issue list

pluginhandler: move attributes to PluginHandler

View original Github issue

Metadata

Project
snapcraft
Number
#3023
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and passing CI. Refactors PluginHandler by moving attributes directly to the class, eliminating duplicates from Project and Project._snap_meta, and cleaning up code across 8 files.

Suggested action:

No scores available.

Issue body

Rely less on setting from the plugin and remove duplicate attributes already held by Project and Project._snap_meta. This involved a general cleanup. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and passing CI. Refactors PluginHandler by moving attributes directly to the class, eliminating duplicates from Project and Project._snap_meta, and cleaning up code across 8 files.
qwen3.6-35b-a3b-mtp-q6 Merged a refactoring that moves attributes to PluginHandler, removing duplicates from Project and Project._snap_meta to reduce reliance on plugin settings.
qwen3.6-35b-a3b-mtp-q6 Merged code cleanup that moved attributes to PluginHandler, eliminating duplicates from Project and Project._snap_meta to reduce reliance on plugin settings.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2329 pluginhandler: remove legacy plugin loading without project snapcraft merged Merged pull request removing legacy plugin loading logic without project support, aligning with the move to bases. Approved by maintainer, passed CI, and successfully integrated into the codebase.
72%
#954 pluginhandler: convert to package snapcraft merged Merged into master. The pluginhandler module was restructured into a package to improve organization. Approved by one reviewer, the change touches four files and maintains full test coverage without impacting overall metrics.
71%