pluginhandler: move attributes to PluginHandler
Metadata
Current evaluation
Merged in snapcraft#3023 (bb268fada), centralizing duplicate plugin attributes in PluginHandler and reducing reliance on mutable plugin-set state.
Resolution: closed resolved
Reason: The cleanup landed through merged PR snapcraft#3023 at commit bb268fada, moving duplicate attributes into PluginHandler and removing redundant state.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Rely less on setting from the plugin and remove duplicate attributes
already held by Project and Project._snap_meta.
This involved a general cleanup.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#3023 (bb268fada), centralizing duplicate plugin attributes in PluginHandler and reducing reliance on mutable plugin-set state. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#3023 (bb268fada), moving duplicate plugin attributes to PluginHandler and reducing reliance on plugin-set state. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and passing CI. Refactors PluginHandler by moving attributes directly to the class, eliminating duplicates from Project and Project._snap_meta, and cleaning up code across 8 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactoring that moves attributes to PluginHandler, removing duplicates from Project and Project._snap_meta to reduce reliance on plugin settings. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1649301 pluginhandler is getting complex | snapcraft (launchpad) | closed | Converted pluginhandler from a module into a package in snapcraft#954, resolving the maintainability concern without changing test coverage. | |
| #923 pluginhandler: source management moved to the core | snapcraft | merged | Merged PR #923 as commit 4c35acef2, moving part source management from plugins into Snapcraft core and incorporating review fixes and property-handling refactors. | |
| #954 pluginhandler: convert to package | snapcraft | merged | Merged PR #954 (commit 121498b9e, Dec 2016) restructuring snapcraft's pluginhandler module into a package, per LP #1649301; pure refactor with no coverage change. |