Sources are getting difficult to maintain

Metadata

Project: snapcraft (launchpad)
Number: #1648906
Type: issue
State: closed
Author: ~kyrofa
Labels: —
Created: 2016-12-09 11:51 PM UTC
Updated: 2016-12-21 06:34 PM UTC
Closed: 2016-12-21 06:34 PM UTC

Current evaluation

Source handlers were split from snapcraft/internal/sources.py into modules by snapcore/snapcraft PRs #957 and #961–#970, resolving the maintainability issue.

Resolution: closed resolved

Reason: The maintainer linked the completed refactor series in the issue: PR #957 and PRs #961–#970 separated the local, Bazaar, Deb, Git, Mercurial, RPM, script, Subversion, Tar, and Zip handlers.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Currently all of the sources are contained in snapcraft/internal/sources.py, which results in a large line count and the ability to get lost. It would be nice to refactor this into a snapcraft/internal/sources package.

Evaluation history

Date	Model	Scores	Action	Summary
2026-10-03 12:23 PM UTC	stealth/space-bunny-alpha	—	closed resolved	Source handlers were split from snapcraft/internal/sources.py into modules by snapcore/snapcraft PRs #957 and #961–#970, resolving the maintainability issue.
2026-10-03 12:23 PM UTC	stealth/space-bunny-alpha	—	closed resolved	Refactored sources into a package via #955 (commit 0ef7dc218), then split individual handlers into modules through #957 and #961–#970.
2026-09-30 10:50 PM UTC	stealth/space-bunny-alpha	—	closed resolved	Resolved by merged PR #955 (commit 0ef7dc218), which converted snapcraft/internal/sources.py into a package; maintainers followed with per-source refactors in #961–#970.
2026-09-25 08:08 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Converted snapcraft/internal/sources.py into a package in merged PR #955 (commit 0ef7dc218), improving maintainability and enabling extraction of individual source handlers.
2026-09-12 06:24 PM UTC	qwen/qwen3.6-35b-a3b	—	—	Proposed refactoring of sources.py into a package was closed without implementation. Zero comments and over nine years of inactivity indicate the request was abandoned or superseded by later codebase changes.
2026-07-23 03:19 PM UTC	qwen/qwen3.6-35b-a3b	—	—	Closed without resolution. The proposal to refactor sources.py into a package was abandoned due to inactivity, with no comments or implementation recorded.
2026-07-22 02:13 PM UTC	qwen/qwen3.6-35b-a3b	—	—	Abandoned. The proposed refactoring of sources.py into a package was not implemented and the issue was closed without resolution.
2026-07-03 10:02 PM UTC	qwen3.6-35b-a3b-mtp-q6	—	—	Refactoring sources.py into a package was closed without resolution. Zero comments and over nine years of inactivity indicate the request was abandoned. No fix or merge occurred.

Update history

Date	Change
2016-12-21 06:34 PM UTC	created

Related work

Likely Fixed By: snapcore/snapcraft#970 (confidence 98%)
Moved Zip-source handling into its own module.
Likely Fixed By: snapcore/snapcraft#961 (confidence 98%)
Moved local-source handling into its own module.
Likely Fixed By: snapcore/snapcraft#962 (confidence 98%)
Moved Bazaar-source handling into its own module.
Likely Fixed By: snapcore/snapcraft#963 (confidence 98%)
Moved Deb-source handling into its own module.
Likely Fixed By: snapcore/snapcraft#964 (confidence 98%)
Moved Git-source handling into its own module.
Likely Fixed By: snapcore/snapcraft#965 (confidence 98%)
Moved Mercurial-source handling into its own module.
Likely Fixed By: snapcore/snapcraft#966 (confidence 98%)
Moved RPM-source handling into its own module.
Likely Fixed By: snapcore/snapcraft#967 (confidence 98%)
Moved script-source handling into its own module.
Likely Fixed By: snapcore/snapcraft#968 (confidence 98%)
Moved Subversion-source handling into its own module.
Likely Fixed By: snapcore/snapcraft#969 (confidence 98%)
Moved Tar-source handling into its own module.
Likely Fixed By: snapcore/snapcraft#957 (confidence 95%)
Initial source refactor linked by the maintainer.

Related issues

Issue	Project	State	Summary	Similarity
#955 sources: convert to package.	snapcraft	merged	Merged PR #955 (commit 0ef7dc218) converted snapcraft/internal/sources.py into a package, groundwork for LP bug #1648906. Follow-ups #957 and #961-#970 then split each source handler into its own module.	72%