← Back to issue list

sources: refactor subversion source into module.

View original Github issue

Metadata

Project
snapcraft
Number
#968
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged refactoring that extracts the Subversion source handler into a dedicated module. Advances Launchpad bug #1648906, passed coverage checks, and received author approval. Net change: +170/-129 lines across four files.

Suggested action:

No scores available.

Issue body

This PR makes more progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by extracting the Subversion source into `sources/_subversion.py`.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged refactoring that extracts the Subversion source handler into a dedicated module. Advances Launchpad bug #1648906, passed coverage checks, and received author approval. Net change: +170/-129 lines across four files.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Refactored Subversion source handling into sources/_subversion.py. The change passed automated coverage checks and received approval from the original author.
qwen3.6-35b-a3b-mtp-q6 Merged into master, refactoring the Subversion source handler into a dedicated module at sources/_subversion.py. The change advances LP #1648906, passes code coverage checks, and received approval from the original author.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#961 sources: refactor local source into module. snapcraft merged Merged after approval and CI. Refactored the local source into sources/_local.py, advancing Launchpad bug #1648906. Modified four files with a +236/-191 line change and slightly increased overall code coverage.
78%
#965 sources: refactor mercurial source into module. snapcraft merged Merged into master after approval and passing CI. The change extracts the Mercurial source handler into a dedicated module, advancing work on bug LP: #1648906. Coverage increased slightly with no unresolved comments.
76%
#962 sources: refactor bazaar source into module. snapcraft merged Merged refactoring that extracts the Bazaar source handler into a dedicated module at sources/_bazaar.py. Approved, passed CI, and slightly improved code coverage as part of ongoing bug resolution.
75%
#957 sources: refactor base sources into module. snapcraft merged Merged following two approvals and passing CI checks. Refactored Base and FileBase sources into sources/_base.py, increasing test coverage by 1.20% and progressing work on Launchpad bug #1648906.
72%
#249 Git source: Support submodules. snapcraft merged Merged implementation adding recursive git cloning to support submodules, resolving Launchpad bug #1536698. Submodules update on pull. Changes affect two files. Merged despite reviewer requests for integration tests.
72%
#966 sources: refactor rpm source into module. snapcraft merged Merged a refactor extracting RPM source logic into a dedicated sources/_rpm.py module. Part of ongoing work on Launchpad bug #1648906, the change modified four files (+131/-90 lines) and slightly increased overall code coverage.
72%
#964 sources: refactor git source into module. snapcraft merged Merged a refactor extracting Git source logic into sources/_git.py. Approved by reviewer, passed CI, and slightly improved code coverage as part of ongoing bug fix LP: #1648906.
71%
#967 sources: refactor script source into module. snapcraft merged Merged refactoring of the Script source into a dedicated module at sources/_script.py, including basic unit tests. Approved, passed CI, and advances progress on Launchpad bug #1648906.
71%
#963 sources: refactor deb source into module. snapcraft merged Merged refactoring changes that extract Deb source logic into a dedicated module at sources/_deb.py. This restructuring advances progress on Launchpad bug #1648906 and passes CI checks with maintained code coverage.
71%