← Back to issue list

sources: refactor mercurial source into module.

View original Github issue

Metadata

Project
snapcraft
Number
#965
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged #965 as commit e42bc812, extracting the Mercurial source handler into sources/_mercurial.py (+210/-169, 4 files) as part of the sources refactor series for LP bug #1648906.

Resolution: closed resolved

Reason: The PR itself is the resolution: it was approved and merged as commit e42bc812 into snapcraft, splitting the Mercurial source handler out of sources.py into sources/_mercurial.py with no functional change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR makes more progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by extracting the Mercurial source into `sources/_mercurial.py`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #965 as commit e42bc812, extracting the Mercurial source handler into sources/_mercurial.py (+210/-169, 4 files) as part of the sources refactor series for LP bug #1648906.
stealth/space-bunny-alpha — closed resolved Merged PR #965 (commit e42bc812) by kyrofa extracting the Mercurial source handler into snapcraft/sources/_mercurial.py (+210/-169, 4 files), continuing the source-module split for LP #1648906; approved with no unresolved comments.
stealth/space-bunny-alpha — closed resolved Merged #965 as commit e42bc812, extracting the Mercurial source handler into sources/_mercurial.py to advance LP #1648906.
qwen/qwen3.6-35b-a3b — — Merged into master after approval and passing CI. The change extracts the Mercurial source handler into a dedicated module, advancing work on bug LP: #1648906. Coverage increased slightly with no unresolved comments.
qwen3.6-35b-a3b-mtp-q6 — — Merged the refactoring of the Mercurial source handler into a dedicated module at sources/_mercurial.py. This change advances progress on LP #1648906 and maintains code coverage at 96.24%.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#964 (confidence 95%)

    Companion PR (commit f9ee3f034) extracting the git source into sources/_git.py for the same LP #1648906 effort

  • Related To: snapcraft#966 (confidence 95%)

    Companion PR (commit 07697e4f4) extracting the rpm source into sources/_rpm.py in the same refactor series

Related issues

Issue Project State Summary Similarity
#968 sources: refactor subversion source into module. snapcraft merged Merged PR #968 as commit ebfd3ea27, extracting the Subversion source handler into sources/_subversion.py and advancing LP #1648906.
76%
#962 sources: refactor bazaar source into module. snapcraft merged Merged into master as commit 770607725, extracting Bazaar source handling into sources/_bazaar.py as progress on Launchpad bug #1648906.
72%