sources: refactor zip source into module.
Metadata
Current evaluation
Merged PR #970 as commit db2a6fb6a, extracting the Zip source handler into sources/_zip.py as progress on LP bug #1648906.
Resolution: closed resolved
Reason: PR snapcraft#970 was merged into master as db2a6fb6a, moving the Zip source implementation into sources/_zip.py and advancing LP bug #1648906.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR makes more progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by extracting the Zip source into `sources/_zip.py`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #970 as commit db2a6fb6a, extracting the Zip source handler into sources/_zip.py as progress on LP bug #1648906. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #970 into master, extracting the Zip source implementation into sources/_zip.py as part of Launchpad bug #1648906. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as db2a6fb6a, extracting the Zip source handler into sources/_zip.py as progress on LP bug #1648906. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #970 refactored the Zip source into sources/_zip.py; commit db2a6fb6a records the change. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactoring that extracts the Zip source handler into a dedicated module at sources/_zip.py. The change improves code organization, passes all CI checks, and yields a minor increase in overall test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by maintainer kyrofa, the Zip source extraction logic was refactored into a dedicated module at sources/_zip.py. This change advances bug LP: #1648906 and increases overall code coverage by less than 0.01%. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1648906
(confidence 99%)
Launchpad bug #1648906 tracked the broader source-handler refactoring effort.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #968 sources: refactor subversion source into module. | snapcraft | merged | Merged PR #968 as commit ebfd3ea27, extracting the Subversion source handler into sources/_subversion.py and advancing LP #1648906. | |
| #523 Support zip files as source | snapcraft | merged | Merged PR #523 (commit c9fe15076) adding zip file support as a part source handler, resolving LP bug #1577062. Retroactively approved by kyrofa. | |
| #962 sources: refactor bazaar source into module. | snapcraft | merged | Merged into master as commit 770607725, extracting Bazaar source handling into sources/_bazaar.py as progress on Launchpad bug #1648906. | |
| #212 sources: add zip file source handler | craft-parts | merged | Merged PR #212 (merge commit 043b3da8, implementation a9b32b31) adding a ZipSource handler in craft_parts/sources/zip_source.py so parts can use 'source-type: zip', with unit tests and docs. | |
| #969 sources: refactor tar source into module. | snapcraft | merged | Merged PR #969 in commit 6fb798890, extracting the Tar source into sources/_tar.py as part of LP #1648906. |