← Back to issue list

style: update linting configuration for ruff 0.9

View original Github issue

Metadata

Project
starbase
Number
#319
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Ruff 0.9 lint configuration update merged into main via commit 45ab05b (PR #319). The unrelated git_describe_command suggestion was deferred to PR #321.

Resolution: closed resolved

Reason: PR #319 was approved and merged into main as commit 45ab05b ("style: update linting configuration for ruff 0.9", +3/-3 across 2 files). Reviewer bepri's request to also apply the git_describe_command change was handled separately in PR #321 (commit 6681521).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? --- @bepri pointed these out in https://github.com/canonical/charmcraft/pull/2074

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Ruff 0.9 lint configuration update merged into main via commit 45ab05b (PR #319). The unrelated git_describe_command suggestion was deferred to PR #321.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#2074 via commit af377cd8, updating lint configuration for Ruff 0.9. The unrelated git_describe_command change was deferred.
qwen/qwen3.6-35b-a3b — — Merged update to linting configuration for ruff 0.9. Approved by one reviewer and passed CI. The minimal two-file change was accepted after the author deferred an unrelated git_describe_command suggestion to a separate PR.
qwen3.6-35b-a3b-mtp-q6 — — Merged update to the linting configuration for ruff 0.9. The branch was rebased on main, with unrelated git_describe_command changes separated into a distinct PR before finalization.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#2074 (confidence 92%)

    Original PR where bepri pointed out these linting configuration changes, prompting #319.

  • Superseded By: canonical/starbase#321 (confidence 90%)

    Separate PR by lengau carrying the deferred git_describe_command change (commit 6681521), which reviewers asked to be split out of #319.

  • Related To: canonical/starbase#320 (confidence 45%)

    Referenced in a thread comment on #319 as fixing the OSV scanner finding, though it is an unrelated lockfile maintenance PR.

Related issues

Issue Project State Summary Similarity
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
86%
#2074 style: update to ruff 0.9.0 formatting charmcraft merged Merged PR #2074 in commit af377cd8, updating formatting for Ruff 0.9.0 to address new lint failures.
86%
#969 style: fix linting issues for ruff 0.9 craft-parts merged Merged as commit f1427855: small Ruff 0.9 lint fixes (+2/-1) across 2 files, following the ruff-pre-commit hook bump to the 0.9.x series.
84%
#408 style: fix linting for ruff 0.12 starbase merged Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12.
84%
#29 style(lint): fix ruff 0.6.0 linting errors craft-platforms merged Merged PR #29 as commit 399c4e0, fixing Ruff 0.6.0 lint errors and switching the pre-commit Ruff hook to rolling versions.
84%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed.
84%
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged PR #4981 as commit 3a1b8a949, fixing Ruff 0.6 lint errors with a minimal one-file change.
83%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
83%
#624 style(lint): fix ruff 0.6.0 linting errors craft-providers merged Merged as commit 823622d, fixing Ruff 0.6.0 lint errors and switching the pre-commit Ruff hook to rolling versions.
82%
#1825 style(lint): fix ruff 0.6.0 linting errors charmcraft merged Merged PR #1825 as commit 7aa2965b, applying Ruff 0.6.0 autofixes across 31 files to resolve linting errors.
82%