lint: ignore ruff SIM117
Metadata
Current evaluation
Merged changes to ignore the ruff SIM117 lint rule, which reduces readability with 88-character line lengths. Approved by a reviewer, passed CI, and updated the lint configuration.
Suggested action: —
No scores available.
Issue body
- [X] Have you followed the guidelines for contributing?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `tox`?
-----
`SIM117` is a good rule in theory. In practice, it seems to make the code less readable (especially with 88 character line lengths).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes to ignore the ruff SIM117 lint rule, which reduces readability with 88-character line lengths. Approved by a reviewer, passed CI, and updated the lint configuration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main to disable the ruff SIM117 rule, which reduced readability under 88-character line limits. The change was integrated without impacting test coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #55 lint: stricter ruff rules | starbase | merged | Merged stricter ruff linting rules. The change modifies one file with 23 additions and 9 deletions, enforces stricter configuration, and received reviewer approval before integration. | |
| #907 style: adjust linting rules for ruff 0.12 | rockcraft | merged | Merged adjustments to Ruff 0.12 linting rules, removing the noqa directive for PLC0415 since it is frequently used in Rockcraft. Approved by two reviewers, passed CI checks, and updated one file with three added lines. | |
| #33 lint: fix lint issues with newer ruff | craft-archives | merged | Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket. | |
| #68 lint: update ruff and fix linting | craft-archives | merged | Merged into main following reviewer approval and passing CI. Updates ruff configuration and resolves linting issues across four files, maintaining 100% diff coverage with no overall coverage change. | |
| #139 style: stricter ruff linters | starbase | merged | Merged stricter ruff linter rules across six files (+50/-33 lines). Approved by four reviewers, passed CI checks, and maintained 100% test coverage. | |
| #408 style: fix linting for ruff 0.12 | starbase | merged | Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration. | |
| #901 style: fix ruff 0.13 linting issues | craft-application | merged | Merged after passing all CI checks and receiving approval from two reviewers. Resolves ruff 0.13 linting issues with a single-line change to one file. | |
| #319 style: update linting configuration for ruff 0.9 | starbase | merged | Merged update to linting configuration for ruff 0.9. Approved by one reviewer and passed CI. The minimal two-file change was accepted after the author deferred an unrelated git_describe_command suggestion to a separate PR. | |
| #4981 style(lint): fix ruff 0.6 linting errors | snapcraft | merged | Merged after receiving two approvals and passing CI checks. Resolves ruff 0.6 linting errors with a minimal one-file change. | |
| #173 style: fix lint for ruff 0.12 | craft-archives | merged | Merged following two approvals and passing CI checks. Resolves lint compatibility for ruff 0.12 while preserving backwards compatibility with ruff 0.11. Applied via a minimal two-line adjustment. |