lint: ignore ruff SIM117
Metadata
Current evaluation
Merged PR #90 (commit f3c4f88) added ruff SIM117 to the ignore list in pyproject.toml, since combining nested with-statements reduced readability at 88-char line lengths.
Resolution: closed resolved
Reason: The PR was merged by maintainer mr-cal as commit f3c4f88 ("lint: ignore ruff SIM117 (#90)"), adding "SIM117" to pyproject.toml's ruff ignore list; the entry is still present in pyproject.toml at current HEAD (line 247).
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the guidelines for contributing?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `tox`?
-----
`SIM117` is a good rule in theory. In practice, it seems to make the code less readable (especially with 88 character line lengths).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #90 (commit f3c4f88) added ruff SIM117 to the ignore list in pyproject.toml, since combining nested with-statements reduced readability at 88-char line lengths. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/starbase#90: Ruff SIM117 was disabled because combining nested with-statements reduced readability with 88-character line lengths. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes to ignore the ruff SIM117 lint rule, which reduces readability with 88-character line lengths. Approved by a reviewer, passed CI, and updated the lint configuration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main to disable the ruff SIM117 rule, which reduced readability under 88-character line limits. The change was integrated without impacting test coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #302 lint: fix ruff warnings SIM102 and SIM114 | craft-providers | merged | Merged PR #302, resolving Ruff SIM102 and SIM114 warnings by simplifying conditional branches (commit 427870d). | |
| #303 lint: fix ruff warnings SIM108, SIM112, SIM117, TRY300 | craft-providers | merged | Merged #303, applying Ruff fixes for SIM108, SIM112, SIM117, and TRY300 across five files; changes landed in commit 2d082e2. | |
| #907 style: adjust linting rules for ruff 0.12 | rockcraft | merged | Merged into main as 186cb0fb, updating Ruff 0.12 settings to ignore PLC0415 and avoid unnecessary noqa comments. |