← Back to issue list

lint: fix ruff warnings SIM102 and SIM114

View original Github issue

Metadata

Project
craft-providers
Number
#302
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #302, resolving Ruff SIM102 and SIM114 warnings by simplifying conditional branches (commit 427870d).

Resolution: closed resolved

Reason: PR #302 was approved and merged as commit 427870d, replacing nested and duplicated conditional branches to eliminate the reported Ruff warnings.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Resolves: - `SIM102`: Use a single `if` statement instead of nested `if` statements - `SIM114`: Combine `if` branches using logical `or` operator

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #302, resolving Ruff SIM102 and SIM114 warnings by simplifying conditional branches (commit 427870d).
qwen/qwen3.6-35b-a3b — closed resolved Merged PR resolving ruff lint warnings SIM102 and SIM114 by simplifying nested conditionals and combining branches with logical OR.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#303 lint: fix ruff warnings SIM108, SIM112, SIM117, TRY300 craft-providers merged Merged #303, applying Ruff fixes for SIM108, SIM112, SIM117, and TRY300 across five files; changes landed in commit 2d082e2.
90%
#90 lint: ignore ruff SIM117 starbase merged Merged PR #90 (commit f3c4f88) added ruff SIM117 to the ignore list in pyproject.toml, since combining nested with-statements reduced readability at 88-char line lengths.
78%
#301 lint: fix ruff warning PLC1901 craft-providers merged Merged PR #301 (commit d547a8f) by maintainer mr-cal replaced `string == ""` checks with `not string` in 4 files (+4/-5), clearing ruff PLC1901 lint warnings.
76%
#415 style: fix ruff 0.16 warning craft-store merged Merged PR #415 as commit b24d684, adding a directive to ignore Ruff 0.16's new warning; all CI checks passed.
74%
#68 lint: update ruff and fix linting craft-archives merged Merged PR #68 as commit 8bb81ae, updating Ruff and fixing lint violations across four files after prerequisite #67.
72%
#33 lint: fix lint issues with newer ruff craft-archives merged PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641.
70%
#55 lint: stricter ruff rules starbase merged Merged PR canonical/starbase#55 as b5cda0d, tightening Ruff lint rules in one file (+23/-9) after maintainer approval.
70%