← Back to issue list

tools: bring tox and linting from starbase

View original Github issue

Metadata

Project
charmcraft
Number
#1061
Type
pull request
State
closed
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Closed without merging due to lack of review and activity. The pull request to integrate tox and linting from starbase was abandoned after three years with no CI checks, comments, or reviewer engagement.

Suggested action:

No scores available.

Issue body

This will definitely be easier to walk through commit by commit, and for the blame layer change to work it will need to be merged unsquashed.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without merging due to lack of review and activity. The pull request to integrate tox and linting from starbase was abandoned after three years with no CI checks, comments, or reviewer engagement.
qwen3.6-35b-a3b-mtp-q6 Merged unsquashed to preserve commit history for blame tracking. Integrated tox and linting configurations from the starbase project.
qwen3.6-35b-a3b-mtp-q6 Merged unsquashed to preserve commit history for blame purposes. Integrated tox and linting configurations from the starbase project.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1062 tools: import tox from starbase charmcraft merged Merged the import of the tox starbase configuration, adding eight files (+302/-0). Approved by one reviewer, the change includes unresolved linter failures that currently prevent CI integration.
80%
#4131 tools: update tox config to latest starbase snapcraft merged Merged: updated tox configuration to the latest starbase version. Approved after passing linting and tests, the change modifies three files to align tooling dependencies.
76%
#741 Work/craft 3602/starflow lint rockcraft closed Starflow linting changes were closed without merging. Lacking reviewer feedback, CI checks, and activity for over 50 days, the pull request was abandoned.
75%
#11 tools: use the starbase tox config craft-grammar merged Merged to adopt the starbase tox configuration. The update adds tox.ini and modifies five configuration files, totaling 183 additions. Approved by one reviewer and integrated into the main branch.
74%
#1231 tools: update tox configuration to starbase v1 charmcraft merged Merged following approval by two reviewers. The update replaces the tox configuration with starbase v1, modifying two files with 52 additions and 66 deletions to standardize the build environment.
73%
#4196 [WIP] tox CI integration improvements snapcraft closed Abandoned without merging. The work-in-progress tox CI integration changes (+2/-1 lines) received no reviews or CI checks and were closed after over a year of inactivity.
73%
#15 feat: make the lint workflow reusable starflow closed Closed without merging. The pull request to make the lint workflow reusable received no reviews, comments, or CI checks, indicating it was likely abandoned or superseded. The proposed changes were not integrated into the codebase.
72%
#390 chore: merge latest starbase craft-application closed Closed without merging. The branch to integrate the latest starbase received no reviews, comments, or CI checks, indicating it was abandoned after 23 days.
72%
#33 feat: add linting CI workflow craft-actions closed Changes to add a linting CI workflow were closed without merging. No reviews or comments were submitted, and the branch was abandoned after 28 days of inactivity.
72%
#422 Integrate with Starbase rockcraft closed Closed without merging due to 46 unresolved review comments and a request to close. The Starbase integration was abandoned after requested changes were never addressed.
71%