← Back to issue list

tools: bring tox and linting from starbase

View original Github issue

Metadata

Project
charmcraft
Number
#1061
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after years of inactivity; its tox import landed separately in canonical/charmcraft#1062 via commit 4ed52927.

Resolution: closed superseded

Reason: PR #1062 replaced the abandoned work by importing Starbase's tox configuration and merged as commit 4ed52927. PR #1061 closed without reviews, comments, or CI activity.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This will definitely be easier to walk through commit by commit, and for the blame layer change to work it will need to be merged unsquashed.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged after years of inactivity; its tox import landed separately in canonical/charmcraft#1062 via commit 4ed52927.
stealth/space-bunny-alpha — closed stale Closed unmerged after years of inactivity, with no reviews, comments, or CI. Its tox work was imported separately by merged PR #1062.
qwen/qwen3.6-35b-a3b — — Closed without merging due to lack of review and activity. The pull request to integrate tox and linting from starbase was abandoned after three years with no CI checks, comments, or reviewer engagement.
qwen3.6-35b-a3b-mtp-q6 — — Merged unsquashed to preserve commit history for blame tracking. Integrated tox and linting configurations from the starbase project.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/charmcraft#1062 (confidence 99%)

    Merged PR #1062 imported the tox configuration as commit 4ed52927.

Related issues

Issue Project State Summary Similarity
#1062 tools: import tox from starbase charmcraft merged Merged as commit 4ed52927, adding Starbase's tox configuration across eight files; CI adoption was deferred because several linters failed.
82%
#1231 tools: update tox configuration to starbase v1 charmcraft merged Merged charmcraft#1231 as commit 81ce65f2, updating the tox configuration to Starbase v1 after approval by two reviewers.
77%
#11 tools: use the starbase tox config craft-grammar merged PR #11 by lengau merged (commit 697e4dd) adding Starbase's tox configuration: tox.ini plus four supporting config files, 183 added lines. tox.ini later dropped in #310 after rebasing on Starbase.
73%
#4131 tools: update tox config to latest starbase snapcraft merged Merged PR #4131 as 89fd9ecb6, updating Snapcraft's tox configuration to the latest Starbase and removing obsolete tox setup.
73%
#4058 tox: fix linters and makefile snapcraft merged PR #4058 by lengau merged as commit be5d4307 ("tox: fix linters and makefile"), correcting linter config in tox.ini and the Makefile after the starbase tox migration (#4046). Codecov reported no coverage change.
73%
#4 tools: Update tox and setuptools to fix breakages starbase merged Merged canonical/starbase#4 in commit 552c132, updating tox and setuptools to fix tooling breakages.
72%
#434 docs: use tox for sphinx docs craft-parts closed Closed unmerged as redundant: canonical/craft-parts#433 merged the broader Starbase tox setup in 7dbf0405; equivalent Sphinx support landed via canonical/snapcraft#4273 at d25b49d63.
71%
#2144 ci: use starbase release workflows charmcraft merged Merged in canonical/charmcraft#2144 via commit 739941a5, replacing tox-based publishing with Starbase release workflows.
70%