← Back to issue list

tools: use the starbase tox config

View original Github issue

Metadata

Project
craft-grammar
Number
#11
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #11 by lengau merged (commit 697e4dd) adding Starbase's tox configuration: tox.ini plus four supporting config files, 183 added lines. tox.ini later dropped in #310 after rebasing on Starbase.

Resolution: closed resolved

Reason: The pull request was approved and merged into main as commit 697e4dd 'tools: use the starbase tox config (#11)', which introduced tox.ini and the accompanying configuration needed to enable it. Later cleanups (e.g. #92 'chore: rebase on starbase' and #310 'feat: remove tox.ini') superseded the file as Starbase tooling evolved, but the change itself landed as intended.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This includes only tox.ini and the necessary configuration changes to enable it. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #11 by lengau merged (commit 697e4dd) adding Starbase's tox configuration: tox.ini plus four supporting config files, 183 added lines. tox.ini later dropped in #310 after rebasing on Starbase.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-grammar#11 to adopt Starbase’s tox configuration, adding tox.ini and four supporting configuration files (183 added lines).
qwen/qwen3.6-35b-a3b — — Merged to adopt the starbase tox configuration. The update adds tox.ini and modifies five configuration files, totaling 183 additions. Approved by one reviewer and integrated into the main branch.

Update history

No update history recorded yet.

Related work

  • Related To: craft-grammar#92 (confidence 70%)

    Commit 9594141 'chore: rebase on starbase (#92)' later superseded this hand-written tox configuration by rebasing on Starbase.

  • Related To: craft-grammar#310 (confidence 70%)

    Commit 6f78e1a 'feat: remove tox.ini (#310)' deleted the tox.ini file introduced by this PR once Starbase-managed tooling made it redundant.

Related issues

Issue Project State Summary Similarity
#1062 tools: import tox from starbase charmcraft merged Merged as commit 4ed52927, adding Starbase's tox configuration across eight files; CI adoption was deferred because several linters failed.
88%
#433 tox: basic tox from starbase craft-parts merged Merged the Starbase-derived tox configuration in PR #433 (commit 7dbf0405), updating 24 files.
83%
#1231 tools: update tox configuration to starbase v1 charmcraft merged Merged charmcraft#1231 as commit 81ce65f2, updating the tox configuration to Starbase v1 after approval by two reviewers.
81%
#4131 tools: update tox config to latest starbase snapcraft merged Merged PR #4131 as 89fd9ecb6, updating Snapcraft's tox configuration to the latest Starbase and removing obsolete tox setup.
80%
#4046 tools: move to the starbase tox configuration snapcraft merged Merged as 618410f11, migrating tools to Starbase's tox configuration and testing Python 3.8/3.10 on Ubuntu 20.04/22.04.
80%
#4058 tox: fix linters and makefile snapcraft merged PR #4058 by lengau merged as commit be5d4307 ("tox: fix linters and makefile"), correcting linter config in tox.ini and the Makefile after the starbase tox migration (#4046). Codecov reported no coverage change.
75%
#1061 tools: bring tox and linting from starbase charmcraft closed Closed unmerged after years of inactivity; its tox import landed separately in canonical/charmcraft#1062 via commit 4ed52927.
73%
#4 tools: Update tox and setuptools to fix breakages starbase merged Merged canonical/starbase#4 in commit 552c132, updating tox and setuptools to fix tooling breakages.
73%
#248 build(deps): update dependency tox-gh to v1.3.3 starbase merged Merged canonical/starbase#248 as ce9ccb9, updating tox-gh from 1.3.2 to 1.3.3 in tox.ini.
72%
#5 base: Align to latest starbase standards craft-archives merged PR merged as commit c9e2971: pulled updated config from starbase into craft-archives, adding tox Sphinx/docs setup (no doc files yet) plus lint fixes; later synced again via 071d217 and 0872a9c.
72%