← Back to issue list

fix(tests): fixes bundle spread test

View original Github issue

Metadata

Project
charmcraft
Number
#1287
Type
pull request
State
merged
Author
syu-w
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1287 (commit f60186ce, CRAFT-2052) fixed the failing bundle spread test by validating YAML with Python and dropping a non-working charm path check, resolving #1262.

Resolution: closed resolved

Reason: The PR was merged with 2 approvals and explicitly states 'Fixes: #1262'. The change swapped manual YAML inspection for a Python-based YAML check and removed the charm path check that was causing false spread-test failures.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Use python to check yaml. Remove charm path check that does not work. Fixes: https://github.com/canonical/charmcraft/issues/1262 CRAFT-2052

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1287 (commit f60186ce, CRAFT-2052) fixed the failing bundle spread test by validating YAML with Python and dropping a non-working charm path check, resolving #1262.
stealth/space-bunny-alpha — closed resolved Merged PR #1287 (f60186ce) fixed the failing bundle spread test by validating YAML with Python and removing the ineffective charm path check, resolving #1262.
qwen/qwen3.6-35b-a3b — — Merged. Resolves issue #1262 and CRAFT-2052 by fixing the bundle spread test. Replaced a failing charm path check with Python-based YAML validation. Approved by two reviewers, passed CI, and successfully executed the large spread test.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for bundle spread test. Replaced YAML validation with Python and removed a broken charm path check. Resolves issue #1262 and CRAFT-2052 following successful spread test execution.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1262 (confidence 95%)

    Parent issue 'Bundle spread tests are failing' closed as a result of this fix.

Related issues

Issue Project State Summary Similarity
#1262 Bundle spread tests are failing charmcraft closed Bundle spread tests were fixed by merged PR #1287 (commit f60186ce), which validated YAML semantically and removed an obsolete charm-path assertion.
85%
#1860 tests(2.7): remove bundle registration test charmcraft merged Merged into 2.7 as c5f0ba23, deleting the obsolete bundle registration spread test and backporting the fix for charmcraft#1855.
77%
#1556 refactor(tests/spread): test with explicit charmcraft.yaml files charmcraft merged Merged PR #1556 in commit 4682b32b, replacing prepare-step manipulation of charmcraft.yaml with explicit spread-test configuration files.
76%
#1324 test(spread): test-deploy charms in large spread tests charmcraft merged Merged PR #1324 via commit a14d6d91, adding test deployment of charms and bundles to large Spread tests.
76%
#2426 fix(test): fix the reactive charm spread test charmcraft merged Merged in canonical/charmcraft#2426 via commit 7c33dd1b, applying a one-line fix to the reactive-charm spread test for CHARMCRAFT-641.
75%
#1266 tests(spread): requirements dependencies charmcraft merged Merged PR #1266 at 97d95b39, adding spread tests for requirements-file and charm-dependency combinations; the PR explicitly fixes #1179.
75%
#1325 test(spread): consolidate basic init/build tests charmcraft merged Merged PR #1325 as commit 90e25caf, consolidating basic Spread init/build tests for CRAFT-2127 and reducing duplicated setup across four files.
74%
#1198 tests: add charm library multiple versions update test charmcraft merged Merged PR #1198 (commit 154bf5d6) added a 120-line regression test covering updates across multiple charm-library versions, linked to #1020/CRAFT-1916.
74%
#1540 fix: template integration tests charmcraft merged Merged PR #1540 as commit f3f82031, updating integration-test templates to use charmcraft.yaml instead of metadata.yaml and completing the stalled change from #1468.
74%
#2032 ci: fixes to several weekly spread tests charmcraft merged Merged PR canonical/charmcraft#2032 as commit 29cb07f3, applying a first pass of fixes to several weekly Spread tests.
74%